From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757310AbcIUMzq (ORCPT ); Wed, 21 Sep 2016 08:55:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40204 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757226AbcIUMzp (ORCPT ); Wed, 21 Sep 2016 08:55:45 -0400 Date: Wed, 21 Sep 2016 14:55:40 +0200 From: Jiri Olsa To: Kim Phillips Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Don Zickus , Joe Mario , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern , Andi Kleen Subject: Re: [PATCH 47/61] perf c2c report: Add cacheline browser Message-ID: <20160921125540.GB16793@krava> References: <1474290610-23241-1-git-send-email-jolsa@kernel.org> <1474290610-23241-48-git-send-email-jolsa@kernel.org> <20160920151007.ad88298262bc99a968c95cd5@arm.com> <20160921082155.GA6480@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160921082155.GA6480@krava> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 21 Sep 2016 12:55:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2016 at 10:21:55AM +0200, Jiri Olsa wrote: > On Tue, Sep 20, 2016 at 03:10:07PM -0500, Kim Phillips wrote: > > On Mon, 19 Sep 2016 15:09:56 +0200 > > Jiri Olsa wrote: > > > > > + /* reset abort key so that it can get Ctrl-C as a key */ > > > + SLang_reset_tty(); > > > + SLang_init_tty(0, 0, 0); > > > > this fails to build on systems without slang: > > > > CC builtin-c2c.o > > builtin-c2c.c: In function ‘perf_c2c__browse_cacheline’: > > builtin-c2c.c:2211:2: error: implicit declaration of function ‘SLang_reset_tty’ [-Werror=implicit-function-declaration] > > SLang_reset_tty(); > > will fix, thanks fixed branch pushed in perf/c2c_v4 jirka