From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935040AbcIUTfm (ORCPT ); Wed, 21 Sep 2016 15:35:42 -0400 Received: from foss.arm.com ([217.140.101.70]:54280 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933320AbcIUTfl (ORCPT ); Wed, 21 Sep 2016 15:35:41 -0400 Date: Wed, 21 Sep 2016 14:35:39 -0500 From: Kim Phillips To: Jiri Olsa Cc: Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Don Zickus , "Joe Mario" , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern , Andi Kleen Subject: Re: [PATCH 47/61] perf c2c report: Add cacheline browser Message-Id: <20160921143539.1cd22910e244865354777483@arm.com> In-Reply-To: <20160921125540.GB16793@krava> References: <1474290610-23241-1-git-send-email-jolsa@kernel.org> <1474290610-23241-48-git-send-email-jolsa@kernel.org> <20160920151007.ad88298262bc99a968c95cd5@arm.com> <20160921082155.GA6480@krava> <20160921125540.GB16793@krava> Organization: ARM X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Sep 2016 14:55:40 +0200 Jiri Olsa wrote: > On Wed, Sep 21, 2016 at 10:21:55AM +0200, Jiri Olsa wrote: > > On Tue, Sep 20, 2016 at 03:10:07PM -0500, Kim Phillips wrote: > > > this fails to build on systems without slang: > > > > > > CC builtin-c2c.o > > > builtin-c2c.c: In function ‘perf_c2c__browse_cacheline’: > > > builtin-c2c.c:2211:2: error: implicit declaration of function ‘SLang_reset_tty’ [-Werror=implicit-function-declaration] > > > SLang_reset_tty(); > > > > will fix, thanks > > fixed branch pushed in perf/c2c_v4 that works much better, thanks. Kim