From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935282AbcIUPP1 (ORCPT ); Wed, 21 Sep 2016 11:15:27 -0400 Received: from mail.kernel.org ([198.145.29.136]:43766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933395AbcIUPPY (ORCPT ); Wed, 21 Sep 2016 11:15:24 -0400 Date: Wed, 21 Sep 2016 12:15:19 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Don Zickus , Joe Mario , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern , Andi Kleen Subject: Re: [PATCH 02/61] perf tools: Remove superfluous initialization of weight Message-ID: <20160921151519.GH4973@kernel.org> References: <1474290610-23241-1-git-send-email-jolsa@kernel.org> <1474290610-23241-3-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1474290610-23241-3-git-send-email-jolsa@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Sep 19, 2016 at 03:09:11PM +0200, Jiri Olsa escreveu: > Removing superfluous initialization of weight, > it's already set to 0 via memset. Thanks, applied. > Link: http://lkml.kernel.org/n/tip-1fmf7sw8p16zwl9q6au10t7c@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/evsel.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 21fd573106ed..f3225a2e6eee 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -1728,7 +1728,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event, > data->cpu = data->pid = data->tid = -1; > data->stream_id = data->id = data->time = -1ULL; > data->period = evsel->attr.sample_period; > - data->weight = 0; > data->cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK; > > if (event->header.type != PERF_RECORD_SAMPLE) { > @@ -1935,7 +1934,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event, > } > } > > - data->weight = 0; > if (type & PERF_SAMPLE_WEIGHT) { > OVERFLOW_CHECK_u64(array); > data->weight = *array; > -- > 2.7.4