From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935416AbcIUPQi (ORCPT ); Wed, 21 Sep 2016 11:16:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53276 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933395AbcIUPQh (ORCPT ); Wed, 21 Sep 2016 11:16:37 -0400 Date: Wed, 21 Sep 2016 11:16:26 -0400 From: Don Zickus To: Jiri Olsa Cc: Stanislav Ievlev , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Joe Mario , Ingo Molnar , Peter Zijlstra , Namhyung Kim , David Ahern , Andi Kleen Subject: Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function Message-ID: <20160921151626.GI98438@redhat.com> References: <1474290610-23241-1-git-send-email-jolsa@kernel.org> <1474290610-23241-6-git-send-email-jolsa@kernel.org> <20160921091829.GA12399@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160921091829.GA12399@krava> User-Agent: Mutt/1.5.23.1 (2014-03-12) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 21 Sep 2016 15:16:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 21, 2016 at 11:18:29AM +0200, Jiri Olsa wrote: > On Wed, Sep 21, 2016 at 09:08:40AM +0000, Stanislav Ievlev wrote: > > Hi, Jiri! > > > > Why are you not using unsigned integer for counters in c2c_stats structure? > > hi, > never really thought of that, because that's one of the original > patches I could take almost untouched.. so no real reason ;-) Hi Jirka, I can't recall the reason Dick and myself started that way. I think it makes sense to use u32 here. So I am fine with it. :-) Cheers, Don > > jirka > > > > > On Mon, Sep 19, 2016 at 4:27 PM Jiri Olsa wrote: > > > > > Introducing c2c_decode_stats function, which decodes > > > data_src data into new struct c2c_stats. > > > > > > +struct c2c_stats { > > > + int nr_entries; > > > + > > > + int locks; /* count of 'lock' transactions */ > > > + int store; /* count of all stores in trace */ > > > + int st_uncache; /* stores to uncacheable address */ > > > + int st_noadrs; /* cacheable store with no address */ > > > + int st_l1hit; /* count of stores that hit L1D */ > > > + int st_l1miss; /* count of stores that miss L1D */ > > > + int load; /* count of all loads in trace */ > > > + int ld_excl; /* exclusive loads, rmt/lcl DRAM - > > > snp none/miss */ > > > + int ld_shared; /* shared loads, rmt/lcl DRAM - snp > > > hit */ > > > + int ld_uncache; /* loads to uncacheable address */ > > > + int ld_io; /* loads to io address */ > > > + int ld_miss; /* loads miss */ > > > + int ld_noadrs; /* cacheable load with no address */ > > > + int ld_fbhit; /* count of loads hitting Fill Buffer > > > */ > > > + int ld_l1hit; /* count of loads that hit L1D */ > > > + int ld_l2hit; /* count of loads that hit L2D */ > > > + int ld_llchit; /* count of loads that hit LLC */ > > > + int lcl_hitm; /* count of loads with local HITM */ > > > + int rmt_hitm; /* count of loads with remote HITM */ > > > + int rmt_hit; /* count of loads with remote hit > > > clean; */ > > > + int lcl_dram; /* count of loads miss to local DRAM > > > */ > > > + int rmt_dram; /* count of loads miss to remote DRAM > > > */ > > > + int nomap; /* count of load/stores with no phys > > > adrs */ > > > + int noparse; /* count of unparsable data sources */ > > > +}; > > > > > >