From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756571AbcIUPcu (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 11:32:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38802 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750846AbcIUPct (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 11:32:49 -0400
Date: Wed, 21 Sep 2016 17:32:45 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Stanislav Ievlev <stanislav.ievlev@gmail.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, Joe Mario <jmario@redhat.com>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function
Message-ID: <20160921153245.GB28272@krava>
References: <1474290610-23241-1-git-send-email-jolsa@kernel.org>
 <1474290610-23241-6-git-send-email-jolsa@kernel.org>
 <CACDz1GupJi3kcDx6zBK68KtpL=Q9hJvUFvHCdtMirMyuuuyMOQ@mail.gmail.com>
 <20160921091829.GA12399@krava>
 <20160921151626.GI98438@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160921151626.GI98438@redhat.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 21 Sep 2016 15:32:49 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 21, 2016 at 11:16:26AM -0400, Don Zickus wrote:
> On Wed, Sep 21, 2016 at 11:18:29AM +0200, Jiri Olsa wrote:
> > On Wed, Sep 21, 2016 at 09:08:40AM +0000, Stanislav Ievlev wrote:
> > > Hi, Jiri!
> > > 
> > > Why are you not using unsigned integer for counters in c2c_stats structure?
> > 
> > hi,
> > never really thought of that, because that's one of the original
> > patches I could take almost untouched.. so no real reason ;-)
> 
> Hi Jirka,
> 
> I can't recall the reason Dick and myself started that way.  I think it
> makes sense to use u32 here.  So I am fine with it. :-)

ok, will change

thanks,
jirka