From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757992AbcIXM7K (ORCPT ); Sat, 24 Sep 2016 08:59:10 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:45393 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcIXM7J (ORCPT ); Sat, 24 Sep 2016 08:59:09 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Sat, 24 Sep 2016 14:58:54 +0200 From: Stefan Richter To: SF Markus Elfring Cc: linux1394-devel@lists.sourceforge.net, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 02/10] firewire-net: Rename a jump label in fwnet_broadcast_start() Message-ID: <20160924145854.60bfba05@kant> In-Reply-To: <1f06a795-8595-9f3d-7eb3-28c9d6c5289c@users.sourceforge.net> References: <566ABCD9.1060404@users.sourceforge.net> <1f06a795-8595-9f3d-7eb3-28c9d6c5289c@users.sourceforge.net> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sep 18 SF Markus Elfring wrote: > Adjust jump labels according to the current Linux coding style > convention. The current CodingStyle says: "Choose label names which say what the goto does or why the goto exists." Given the choice between /what/ and /why/, I for one lean towards /why/. In this instance, the what and why is "clean up and exit after an error occurred". 'failed' looks to me to be a better shorthand of this than 'stop_broadcast'. The latter merely says /how/ the cleanup is done. > Signed-off-by: Markus Elfring > --- > drivers/firewire/net.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c > index 7911f13..89afed3 100644 > --- a/drivers/firewire/net.c > +++ b/drivers/firewire/net.c > @@ -1106,7 +1106,7 @@ static int fwnet_broadcast_start(struct > fwnet_device *dev) ptrptr = kmalloc_array(num_packets, sizeof(*ptrptr), > GFP_KERNEL); if (!ptrptr) { > retval = -ENOMEM; > - goto failed; > + goto stop_broadcast; > } > dev->broadcast_rcv_buffer_ptrs = ptrptr; > > @@ -1116,13 +1116,13 @@ static int fwnet_broadcast_start(struct > fwnet_device *dev) fwnet_receive_broadcast, dev); > if (IS_ERR(context)) { > retval = PTR_ERR(context); > - goto failed; > + goto stop_broadcast; > } [...] > @@ -1166,8 +1166,7 @@ static int fwnet_broadcast_start(struct > fwnet_device *dev) dev->broadcast_state = FWNET_BROADCAST_RUNNING; > > return 0; > - > - failed: > + stop_broadcast: > __fwnet_broadcast_stop(dev); > return retval; > } I see no reason to remove the blank line between the return statement and the label. -- Stefan Richter -======----- =--= ==--- http://arcgraph.de/sr/