From: Mark Brown <broonie@kernel.org>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Helen Koike <helen.koike@collabora.co.uk>,
Lars-Peter Clausen <lars@metafoo.de>,
Sebastian Reichel <sre@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH] ASoC: tpa6130a2: fix volume setting when no stream is running
Date: Sat, 24 Sep 2016 19:31:10 +0100 [thread overview]
Message-ID: <20160924183110.s4lxuigycpxegamq@sirena.org.uk> (raw)
In-Reply-To: <1474539040-25347-1-git-send-email-nikita.yoush@cogentembedded.com>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
On Thu, Sep 22, 2016 at 01:10:40PM +0300, Nikita Yushchenko wrote:
> - ret = regulator_disable(data->supply);
> - if (ret != 0) {
> + ret2 = regulator_disable(data->supply);
> + if (ret2 != 0) {
> dev_err(data->dev,
> - "Failed to disable supply: %d\n", ret);
> - return ret;
> + "Failed to disable supply: %d\n", ret2);
> + return ret ? ret : ret2;
> }
The ternery operator to save the error handling block is a bit too cute
to be clear, it'd be better to just handle each error directly. Can you
please send a followup patch fixing this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2016-09-25 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 10:10 [PATCH] ASoC: tpa6130a2: fix volume setting when no stream is running Nikita Yushchenko
2016-09-24 18:31 ` Mark Brown [this message]
2016-09-26 10:35 ` [PATCH] ASoC: tpa6130a2: unmerge power enable error path from power disable path Nikita Yushchenko
2016-09-26 16:08 ` Mark Brown
2016-09-26 16:14 ` Nikita Yushchenko
2016-09-26 16:15 ` Applied "ASoC: tpa6130a2: unmerge power enable error path from power disable path" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160924183110.s4lxuigycpxegamq@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cphealy@gmail.com \
--cc=helen.koike@collabora.co.uk \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=perex@perex.cz \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).