From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755581AbcIZIfm (ORCPT ); Mon, 26 Sep 2016 04:35:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47960 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754259AbcIZIfj (ORCPT ); Mon, 26 Sep 2016 04:35:39 -0400 Date: Mon, 26 Sep 2016 10:35:33 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Arnaldo Carvalho de Melo , Sukadev Bhattiprolu , peterz@infradead.org, maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v21 00/20] perf, tools: Add support for PMU events in JSON format Message-ID: <20160926083533.GA15523@krava> References: <1473978296-20712-1-git-send-email-sukadev@linux.vnet.ibm.com> <20160919212017.GA11991@kernel.org> <20160919233113.GB11991@kernel.org> <20160919233753.GC11991@kernel.org> <20160920000258.GD11991@kernel.org> <20160920002820.GE11991@kernel.org> <20160922150022.GA20134@krava> <20160922162713.GA31617@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160922162713.GA31617@krava> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 26 Sep 2016 08:35:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 22, 2016 at 06:27:13PM +0200, Jiri Olsa wrote: > On Thu, Sep 22, 2016 at 05:00:22PM +0200, Jiri Olsa wrote: > > On Mon, Sep 19, 2016 at 09:28:20PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Sep 19, 2016 at 09:02:58PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Mon, Sep 19, 2016 at 08:37:53PM -0300, Arnaldo Carvalho de Melo escreveu: > > > > > yeah, changing that typedef + true def to plain include > > > > > makes it progress to the next failure, which is in cross compilation > > > > > environments, such as using fedora 24 + the Android NDK to try to build > > > > > a ARM android binary. > > > > > > > 14 fedora:24-x-ARC-uClibc: FAIL > > > > GEN /tmp/build/perf/pmu-events/pmu-events.c > > > > /bin/sh: /tmp/build/perf/pmu-events/jevents: cannot execute binary file: Exec format error > > > > pmu-events/Build:11: recipe for target '/tmp/build/perf/pmu-events/pmu-events.c' failed > > > > make[2]: *** [/tmp/build/perf/pmu-events/pmu-events.c] Error 126 > > > > Makefile.perf:461: recipe for target '/tmp/build/perf/pmu-events/pmu-events-in.o' failed > > > > make[1]: *** [/tmp/build/perf/pmu-events/pmu-events-in.o] Error 2 > > > > make[1]: *** Waiting for unfinished jobs.... > > > > > > Jiri, we need something similar to scripts/Makefile.host :-\ > > > > > > Calling it a day, perhaps, for now, we should just detect that it is a > > > corss compile env (CROSS_COMPILE is set) and exclude all this code from > > > the build, emitting a warning. > > > > > > I left what I did at the tmp.perf/core branch of my repo at > > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git. > > > > as discussed on irc we will disable it for cross builds now, > > because we dont have good solution at the moment.. it's > > similar case as for fixdep tool: > > > > 3a70fcd3a4db tools build: Fix cross compile build > > ... > > We need to add support for host side tools build, meanwhile > > disabling fixdep usage for cross arch builds. > > > > I'll make a change to disable this for crossbuild and > > work on common solution later > > could you please give it a try with patch below? > I tested but not with properly cross building... > > also, did you want some message during the cross build that pmu-events are not included? ping.. is that working for you? IMO we can include this as additional patch to the set.. thanks, jirka