From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754493AbcI0KpG (ORCPT ); Tue, 27 Sep 2016 06:45:06 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58910 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753884AbcI0Koz (ORCPT ); Tue, 27 Sep 2016 06:44:55 -0400 Date: Tue, 27 Sep 2016 12:44:58 +0200 From: Greg KH To: Amit Ghadge Cc: mdharm-usb@one-eyed-alien.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: storage: alauda: Clean up if function returned NULL on failure Message-ID: <20160927104458.GB11899@kroah.com> References: <1473787131-11114-1-git-send-email-amitg.b14@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473787131-11114-1-git-send-email-amitg.b14@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2016 at 10:48:51PM +0530, Amit Ghadge wrote: > Some functions return NULL on failure, used !x instead of x==NULL. > > Signed-off-by: Amit Ghadge > --- > drivers/usb/storage/alauda.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Same mailing list comment here...