From: Greg KH <gregkh@linuxfoundation.org>
To: "Manuel Schölling" <manuel.schoelling@gmx.de>
Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, jslaby@suse.cz,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] console: Add persistent scrollback buffers for all VGA consoles
Date: Tue, 27 Sep 2016 12:58:42 +0200 [thread overview]
Message-ID: <20160927105842.GA3922@kroah.com> (raw)
In-Reply-To: <1474236417-27150-1-git-send-email-manuel.schoelling@gmx.de>
On Mon, Sep 19, 2016 at 12:06:57AM +0200, Manuel Schölling wrote:
> Add a scrollback buffers for each VGA console. The benefit is that
> the scrollback history is not flushed when switching between consoles
> but is persistent.
> The buffers are allocated on demand when a new console is opened.
>
> It always annoys me when I switch back to a console and I can just
> read half of an error backtrace. This should fix issues like these.
>
> This breaks tools like clear_console that rely on flushing the
> scrollback history by switching back and forth between consoles
> which is why this feature is disabled by default.
> Use the escape sequence \e[3J instead for flushing the buffer.
>
> Signed-off-by: Manuel Schölling <manuel.schoelling@gmx.de>
> ---
> Changes in v3:
> - Add config option for this feature
> - Fallback to old scrollback buffer if kcalloc() fails
> - Remove ioctl() call again and add documentation about existing
> escape sequence to flush the scrollback buffer
> Changes in v2:
> - Add ioctl() call to flush scrollback buffer
> - (Patch v2 was not labeled as such, sorry)
> ---
> drivers/video/console/Kconfig | 23 +++++-
> drivers/video/console/vgacon.c | 160 +++++++++++++++++++++++++++--------------
> 2 files changed, 128 insertions(+), 55 deletions(-)
I need someone else to at least test this, and give an acked-by for
it...
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-27 10:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-18 22:06 [PATCH v3] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling
2016-09-19 18:16 ` Manuel Schölling
2016-09-27 10:58 ` Greg KH [this message]
2016-11-10 21:47 ` Andrey Utkin
2016-11-16 17:38 ` [PATCH v4] console: Add persistent scrollback buffers for all VGA console Manuel Schölling
2016-11-16 20:30 ` [PATCH v4.1 0/2] " Manuel Schölling
2016-11-16 20:30 ` [PATCH v4.1 1/2] console: Move scrollback data into its own struct Manuel Schölling
2016-11-16 20:31 ` [PATCH v4.1 2/2] console: Add persistent scrollback buffers for all VGA consoles Manuel Schölling
2016-11-16 21:40 ` kbuild test robot
2016-11-16 17:40 ` [PATCH v3] " Manuel Schölling
-- strict thread matches above, loose matches on Subject: below --
2016-09-14 15:27 Manuel Schölling
2016-09-06 18:58 Manuel Schölling
2016-08-27 16:04 Manuel Schölling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927105842.GA3922@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.schoelling@gmx.de \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).