From: Masami Hiramatsu <mhiramat@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH perf/core 0/4] perf-probe fixes for C++
Date: Tue, 27 Sep 2016 11:11:41 -0700 [thread overview]
Message-ID: <20160927111141.50d573073428b6aa5cdda562@kernel.org> (raw)
In-Reply-To: <20160925111421.GA11277@krava>
On Sun, 25 Sep 2016 13:14:21 +0200
Jiri Olsa <jolsa@redhat.com> wrote:
> On Sat, Sep 24, 2016 at 12:34:47AM +0900, Masami Hiramatsu wrote:
> > Hi,
> >
> > Here is a series of patches for fixing several issues when
> > probing on C++ binaries.
> >
> > - Ignore inlined function definition if it has no instance [1/4]
> > - Skip (inlined/normal) functions which entry address is 0 [2/4]
> > - Cut off the filename for group name if it includes characters
> > which can not be used for C symbol name [3/4]
> > - Search mangled symbol name from debuginfo [4/4]
> >
> > So, with this series, perf-probe can handle "mangled symbol" or
> > "method name" as below;
> > ----
> > $ ./perf probe -x /usr/lib64/libstdc++.so.6 \
> > -D _ZNKSt15basic_fstreamXXIwSt11char_traitsIwEE7is_openEv
> > p:probe_libstdc/_ZNKSt15basic_fstreamXXIwSt11char_traitsIwEE7is_openEv
> > /usr/lib64/libstdc++.so.6.0.22:0x8ca60
> >
> > $ ./perf probe -x /usr/lib64/libstdc++.so.6 -D is_open
> > p:probe_libstdc/is_open /usr/lib64/libstdc++.so.6.0.22:0x8ca80
> > p:probe_libstdc/is_open_1 /usr/lib64/libstdc++.so.6.0.22:0x8ca70
> > p:probe_libstdc/is_open_2 /usr/lib64/libstdc++.so.6.0.22:0x8ca60
> > p:probe_libstdc/is_open_3 /usr/lib64/libstdc++.so.6.0.22:0xb0ad0
> > p:probe_libstdc/is_open_4 /usr/lib64/libstdc++.so.6.0.22:0xecca9
> > ----
> >
> > Jiri and Thomas, could you try this if you need it?
>
> tried examples from changelogs and it works for me
>
> Tested-by: Jiri Olsa <jolsa@kernel.org>
Thanks Jiri!
>
> thanks,
> jirka
>
> >
> > TODO:
> > - Support demangled method name(in short), like std::basic_fstream::is_open.
> >
> > Thank you,
> >
> > ---
> >
> > Masami Hiramatsu (4):
> > perf-probe: Ignore the error of finding inline instance
> > perf-probe: Skip if the function address is 0
> > perf-probe: Fix to cut off incompatible chars from group name
> > perf-probe: Match linkage name with mangled name
> >
> >
> > tools/perf/util/dwarf-aux.c | 28 ++++++++++++++++++++++++++--
> > tools/perf/util/dwarf-aux.h | 3 +++
> > tools/perf/util/probe-event.c | 10 +++++++---
> > tools/perf/util/probe-finder.c | 17 ++++++++++++++---
> > 4 files changed, 50 insertions(+), 8 deletions(-)
> >
> > --
> > Masami Hiramatsu
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2016-09-27 18:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 15:34 [PATCH perf/core 0/4] perf-probe fixes for C++ Masami Hiramatsu
2016-09-23 15:34 ` [PATCH perf/core 1/4] perf-probe: Ignore the error of finding inline instance Masami Hiramatsu
2016-09-29 18:19 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2016-09-23 15:35 ` [PATCH perf/core 2/4] perf-probe: Skip if the function address is 0 Masami Hiramatsu
2016-09-29 18:19 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2016-09-23 15:35 ` [PATCH perf/core 3/4] perf-probe: Fix to cut off incompatible chars from group name Masami Hiramatsu
2016-09-29 18:20 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2016-09-23 15:35 ` [PATCH perf/core 4/4] perf-probe: Match linkage name with mangled name Masami Hiramatsu
2016-09-29 18:20 ` [tip:perf/core] perf probe: " tip-bot for Masami Hiramatsu
2016-09-25 11:14 ` [PATCH perf/core 0/4] perf-probe fixes for C++ Jiri Olsa
2016-09-27 18:11 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927111141.50d573073428b6aa5cdda562@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).