From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755241AbcI0Sw5 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Sep 2016 14:52:57 -0400
Received: from eddie.linux-mips.org ([148.251.95.138]:58214 "EHLO
        cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753214AbcI0Swt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Sep 2016 14:52:49 -0400
Date: Tue, 27 Sep 2016 20:52:37 +0200
From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org, Mauro Carvalho Chehab <mchehab@kernel.org>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
        linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
        "David S. Miller" <davem@davemloft.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 17/19] auxdisplay: img-ascii-lcd: driver for simple
 ASCII LCD displays
Message-ID: <20160927185237.GG12981@linux-mips.org>
References: <20160826141751.13121-1-paul.burton@imgtec.com>
 <20160826141751.13121-18-paul.burton@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160826141751.13121-18-paul.burton@imgtec.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 26, 2016 at 03:17:49PM +0100, Paul Burton wrote:

> Add a driver for simple ASCII LCD displays found on the MIPS Boston,
> Malta & SEAD3 development boards. The Boston display is an independent
> memory mapped device with a simple memory mapped 8 byte register space
> containing the 8 ASCII characters to display. The Malta display is
> exposed as part of the Malta board registers, and provides 8 registers
> each of which corresponds to one of the ASCII characters to display. The
> SEAD3 display is slightly more complex, exposing an interface to an
> S6A0069 LCD controller via registers provided by the boards CPLD.
> However although the displays differ in their register interface, we
> require similar functionality on each board so abstracting away the
> differences within a single driver allows us to share a significant
> amount of code & ensure consistent behaviour.
> 
> The driver displays the Linux kernel version as the default message, but
> allows the message to be changed via a character device. Messages longer
> then the number of characters that the display can show will scroll.
> 
> This provides different behaviour to the existing LCD display code for
> the MIPS Malta or MIPS SEAD3 platforms in the following ways:
> 
>   - The default string to display is not "LINUX ON MALTA" or "LINUX ON
>     SEAD3" but "Linux" followed by the version number of the kernel
>     (UTS_RELEASE).
> 
>   - Since that string tends to be significantly longer it scrolls twice
>     as fast, moving every 500ms rather than every 1s.
> 
>   - The LCD won't be updated until the driver is probed, so it doesn't
>     provide the early "LINUX" string.

Right now parts 15..18 of this series are stalled due to the lack of an
ack for this patch.

Miguel?

  Ralf