From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
mgorman@techsingularity.net, Laura Abbott <lauraa@codeaurora.org>,
Minchan Kim <minchan@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Michal Nazarewicz <mina86@mina86.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/6] mm/cma: populate ZONE_CMA
Date: Wed, 28 Sep 2016 14:34:08 +0900 [thread overview]
Message-ID: <20160928053408.GD22706@js1304-P5Q-DELUXE> (raw)
In-Reply-To: <24b9e9e5-0580-b19d-9501-44a19555b4b7@suse.cz>
On Thu, Sep 22, 2016 at 05:59:46PM +0200, Vlastimil Babka wrote:
> On 09/22/2016 08:50 AM, Joonsoo Kim wrote:
> >On Thu, Sep 22, 2016 at 02:45:46PM +0900, Joonsoo Kim wrote:
> >>>
> >>> > /* Free whole pageblock and set its migration type to MIGRATE_CMA. */
> >>> > void __init init_cma_reserved_pageblock(struct page *page)
> >>> > {
> >>> > unsigned i = pageblock_nr_pages;
> >>> >+ unsigned long pfn = page_to_pfn(page);
> >>> > struct page *p = page;
> >>> >+ int nid = page_to_nid(page);
> >>> >+
> >>> >+ /*
> >>> >+ * ZONE_CMA will steal present pages from other zones by changing
> >>> >+ * page links so page_zone() is changed. Before that,
> >>> >+ * we need to adjust previous zone's page count first.
> >>> >+ */
> >>> >+ adjust_present_page_count(page, -pageblock_nr_pages);
> >>> >
> >>> > do {
> >>> > __ClearPageReserved(p);
> >>> > set_page_count(p, 0);
> >>> >- } while (++p, --i);
> >>> >+
> >>> >+ /* Steal pages from other zones */
> >>> >+ set_page_links(p, ZONE_CMA, nid, pfn);
> >>> >+ } while (++p, ++pfn, --i);
> >>> >+
> >>> >+ adjust_present_page_count(page, pageblock_nr_pages);
> >>>
> >>> This seems to assign pages to ZONE_CMA on the proper node, which is
> >>> good. But then ZONE_CMA on multiple nodes will have unnecessary
> >>> holes in the spanned pages, as each will contain only a subset.
> >>
> >>True, I will fix it and respin the series.
> >
> >I now realize that it's too late to send full series for next
> >merge window. I will send full series after next merge window is closed.
>
> I think there might still be rc8 thus another week.
Indeed. I will send full series, soon.
>
> >Anyway, I'd like to confirm that following incremental patch will solve
> >your concern.
>
> Yeah that should work, as long as single cma areas don't include multiple nodes?
Single cma areas cannot include multiple nodes at least until now.
There is a check that single cma area is on a single zone.
Thanks.
>
> >Thanks.
> >
> >
> >------>8--------------
> > mm/cma.c | 25 ++++++++++++++++---------
> > 1 file changed, 16 insertions(+), 9 deletions(-)
> >
> >diff --git a/mm/cma.c b/mm/cma.c
> >index d69bdf7..8375554 100644
> >--- a/mm/cma.c
> >+++ b/mm/cma.c
> >@@ -146,22 +146,29 @@ static int __init cma_init_reserved_areas(void)
> > {
> > int i;
> > struct zone *zone;
> >- unsigned long start_pfn = UINT_MAX, end_pfn = 0;
> >+ pg_data_t *pgdat;
> >
> > if (!cma_area_count)
> > return 0;
> >
> >- for (i = 0; i < cma_area_count; i++) {
> >- if (start_pfn > cma_areas[i].base_pfn)
> >- start_pfn = cma_areas[i].base_pfn;
> >- if (end_pfn < cma_areas[i].base_pfn + cma_areas[i].count)
> >- end_pfn = cma_areas[i].base_pfn + cma_areas[i].count;
> >- }
> >+ for_each_online_pgdat(pgdat) {
> >+ unsigned long start_pfn = UINT_MAX, end_pfn = 0;
> >
> >- for_each_zone(zone) {
> >- if (!is_zone_cma(zone))
> >+ for (i = 0; i < cma_area_count; i++) {
> >+ if (page_to_nid(pfn_to_page(cma_areas[i].base_pfn)) !=
>
> We have pfn_to_nid() (although the implementation is just like this).
Will fix.
Thanks.
next prev parent reply other threads:[~2016-09-28 5:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 5:07 [PATCH v5 0/6] Introduce ZONE_CMA js1304
2016-08-29 5:07 ` [PATCH v5 1/6] mm/page_alloc: don't reserve ZONE_HIGHMEM for ZONE_MOVABLE request js1304
2016-09-16 3:14 ` Aneesh Kumar K.V
2016-09-22 5:30 ` Joonsoo Kim
2016-09-21 9:06 ` Vlastimil Babka
2016-08-29 5:07 ` [PATCH v5 2/6] mm/cma: introduce new zone, ZONE_CMA js1304
2016-08-30 10:35 ` Aneesh Kumar K.V
2016-08-30 12:40 ` Aneesh Kumar K.V
2016-08-31 7:58 ` Joonsoo Kim
2016-09-21 9:11 ` Vlastimil Babka
2016-08-29 5:07 ` [PATCH v5 3/6] mm/cma: populate ZONE_CMA js1304
2016-09-21 9:20 ` Vlastimil Babka
2016-09-22 5:45 ` Joonsoo Kim
2016-09-22 6:50 ` Joonsoo Kim
2016-09-22 15:59 ` Vlastimil Babka
2016-09-28 5:34 ` Joonsoo Kim [this message]
2016-08-29 5:07 ` [PATCH v5 4/6] mm/cma: remove ALLOC_CMA js1304
2016-08-29 5:07 ` [PATCH v5 5/6] mm/cma: remove MIGRATE_CMA js1304
2016-08-29 5:07 ` [PATCH v5 6/6] mm/cma: remove per zone CMA stat js1304
2016-08-29 9:27 ` [PATCH v5 0/6] Introduce ZONE_CMA Aneesh Kumar K.V
2016-08-30 8:21 ` Joonsoo Kim
2016-08-30 10:39 ` Aneesh Kumar K.V
2016-08-31 8:03 ` Joonsoo Kim
2016-09-01 5:47 ` Aneesh Kumar K.V
2016-09-01 6:01 ` Joonsoo Kim
2016-09-21 14:47 ` Aneesh Kumar K.V
2016-09-22 5:32 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928053408.GD22706@js1304-P5Q-DELUXE \
--to=iamjoonsoo.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=lauraa@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@techsingularity.net \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).