From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752152AbcJCFWb (ORCPT ); Mon, 3 Oct 2016 01:22:31 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:38302 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbcJCFW1 (ORCPT ); Mon, 3 Oct 2016 01:22:27 -0400 Date: Mon, 03 Oct 2016 01:20:09 -0400 (EDT) Message-Id: <20161003.012009.1450378180856178912.davem@davemloft.net> To: baoyou.xie@linaro.org Cc: hariprasad@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: Re: [PATCH] cxgb4: mark cxgb_setup_tc() static From: David Miller In-Reply-To: <1475220865-18321-1-git-send-email-baoyou.xie@linaro.org> References: <1475220865-18321-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 02 Oct 2016 22:22:18 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Baoyou Xie Date: Fri, 30 Sep 2016 15:34:25 +0800 > We get 1 warning when building kernel with W=1: > drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c:2715:5: warning: no previous prototype for 'cxgb_setup_tc' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > so this patch marks this function with 'static'. > > Signed-off-by: Baoyou Xie Applied.