From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
devicetree@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com,
agross@codeaurora.org, arnd@arndb.de,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Dan Williams <dan.j.williams@intel.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF
Date: Mon, 3 Oct 2016 09:08:52 +0530 [thread overview]
Message-ID: <20161003033851.GP2467@localhost> (raw)
In-Reply-To: <da6536a3-353e-1364-7074-9d3dcbcc4171@codeaurora.org>
On Sat, Oct 01, 2016 at 11:15:00AM -0400, Sinan Kaya wrote:
> On 10/1/2016 2:17 AM, Vinod Koul wrote:
> > On Wed, Sep 28, 2016 at 10:12:41PM -0400, Sinan Kaya wrote:
> >> Configure the DMA bindings for the device tree based firmware.
> >>
> >> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> >> ---
> >> drivers/dma/qcom/hidma_mgmt.c | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
> >> index 82f36e4..e8f6b84 100644
> >> --- a/drivers/dma/qcom/hidma_mgmt.c
> >> +++ b/drivers/dma/qcom/hidma_mgmt.c
> >> @@ -375,8 +375,11 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
> >> ret = PTR_ERR(new_pdev);
> >> goto out;
> >> }
> >> + of_node_get(child);
> >> + new_pdev->dev.of_node = child;
> >> of_dma_configure(&new_pdev->dev, child);
> >> -
> >> + of_msi_configure(&new_pdev->dev, child);
> >> + of_node_put(child);
> >
> > should this be done unconditionally? Dont we needto call this only for
> > platforms with msi?
>
> I followed the pattern in of_platform_device_create_pdata function. of_msi_configure does
> nothing if MSI is not enabled as irq_find_matching_host returns NULL. It didn't have any
> side effects on my testing either.
yeah later on I did look up the of_msi_configure() and I suspected this. I
think it would be worthwhile to document this assumption here.
Thanks
--
~Vinod
next prev parent reply other threads:[~2016-10-03 3:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1475115167-5898-1-git-send-email-okaya@codeaurora.org>
2016-09-29 2:12 ` [PATCH V4 01/10] Documentation: DT: qcom_hidma: update binding for MSI Sinan Kaya
2016-09-29 2:12 ` [PATCH V4 02/10] Documentation: DT: qcom_hidma: correct spelling mistakes Sinan Kaya
2016-09-29 2:12 ` [PATCH V4 03/10] of: irq: make of_msi_configure accessible from modules Sinan Kaya
2016-09-29 2:12 ` [PATCH V4 04/10] dmaengine: qcom_hidma: configure DMA and MSI for OF Sinan Kaya
2016-10-01 6:17 ` Vinod Koul
2016-10-01 15:15 ` Sinan Kaya
2016-10-03 3:38 ` Vinod Koul [this message]
2016-10-03 13:39 ` Sinan Kaya
2016-09-29 2:12 ` [PATCH V4 05/10] dmaengine: qcom_hidma: make pending_tre_count atomic Sinan Kaya
2016-10-01 6:19 ` Vinod Koul
2016-10-01 15:19 ` Sinan Kaya
2016-10-03 3:39 ` Vinod Koul
2016-09-29 2:12 ` [PATCH V4 06/10] dmaengine: qcom_hidma: make error and success path common Sinan Kaya
2016-09-29 2:12 ` [PATCH V4 07/10] dmaengine: qcom_hidma: bring out interrupt cause Sinan Kaya
2016-09-29 2:12 ` [PATCH V4 08/10] dmaengine: qcom_hidma: add a common API to setup the interrupt Sinan Kaya
2016-09-29 2:12 ` [PATCH V4 09/10] dmaengine: qcom_hidma: protect common data structures Sinan Kaya
2016-09-29 2:12 ` [PATCH V4 10/10] dmaengine: qcom_hidma: add MSI support for interrupts Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161003033851.GP2467@localhost \
--to=vinod.koul@intel.com \
--cc=agross@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=cov@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).