From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752503AbcJCPw0 (ORCPT ); Mon, 3 Oct 2016 11:52:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41512 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbcJCPwY (ORCPT ); Mon, 3 Oct 2016 11:52:24 -0400 Date: Mon, 3 Oct 2016 17:51:12 +0200 From: Oleg Nesterov To: Robert Ho Cc: pbonzini@redhat.com, akpm@linux-foundation.org, mhocko@suse.com, dave.hansen@intel.com, dan.j.williams@intel.com, guangrong.xiao@linux.intel.com, gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, stefanha@redhat.com, yuhuang@redhat.com, linux-mm@kvack.org, ross.zwisler@linux.intel.com Subject: Re: [PATCH v4 1/2] mm, proc: Fix region lost in /proc/self/smaps Message-ID: <20161003155111.GA4758@redhat.com> References: <1475296958-27652-1-git-send-email-robert.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475296958-27652-1-git-send-email-robert.hu@intel.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 03 Oct 2016 15:52:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01, Robert Ho wrote: > > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -147,7 +147,7 @@ m_next_vma(struct proc_maps_private *priv, struct vm_area_struct *vma) > static void m_cache_vma(struct seq_file *m, struct vm_area_struct *vma) > { > if (m->count < m->size) /* vma is copied successfully */ > - m->version = m_next_vma(m->private, vma) ? vma->vm_start : -1UL; > + m->version = m_next_vma(m->private, vma) ? vma->vm_end : -1UL; > } > > static void *m_start(struct seq_file *m, loff_t *ppos) > @@ -175,8 +175,10 @@ static void *m_start(struct seq_file *m, loff_t *ppos) > priv->tail_vma = get_gate_vma(mm); > > if (last_addr) { > - vma = find_vma(mm, last_addr); > - if (vma && (vma = m_next_vma(priv, vma))) > + vma = find_vma(mm, last_addr - 1); > + if (vma && vma->vm_start <= last_addr) > + vma = m_next_vma(priv, vma); > + if (vma) > return vma; > } Acked-by: Oleg Nesterov