From: Chen Yu <yu.c.chen@intel.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: linux-pm@vger.kernel.org, x86@kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@suse.de>,
Pavel Machek <pavel@ucw.cz>, Brian Gerst <brgerst@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Varun Koyyalagunta <cpudebug@centtech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4][RFC v2] PM / sleep: Introduce arch-specific hook for disable/enable nonboot cpus
Date: Sun, 9 Oct 2016 00:58:43 +0800 [thread overview]
Message-ID: <20161008165843.GB24225@sharon> (raw)
In-Reply-To: <8f0aeb0a-5e72-8327-2406-a78ad783f6f2@kernel.org>
Hi Andy,
On Fri, Oct 07, 2016 at 12:31:41PM -0700, Andy Lutomirski wrote:
> On 06/25/2016 09:18 AM, Chen Yu wrote:
> >There is requirement that we need to do some arch-specific
> >operations before putting the nonboot CPUs offline/online.
> >One of the requirements comes from the hibernation resume
> >process on x86_64, we need to kick all the offlin-CPUs
> >online and offline again, in order to put them in a safe
> >state, thus to avoid possible unwilling wake up during
> >hibernation resume.
> >
> >Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> >---
> > kernel/cpu.c | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> >diff --git a/kernel/cpu.c b/kernel/cpu.c
> >index d25266e..ce6e5e4 100644
> >--- a/kernel/cpu.c
> >+++ b/kernel/cpu.c
> >@@ -1017,6 +1017,16 @@ EXPORT_SYMBOL_GPL(cpu_up);
> > #ifdef CONFIG_PM_SLEEP_SMP
> > static cpumask_var_t frozen_cpus;
> >
> >+void __weak arch_disable_nonboot_cpus_pre(void)
>
> I don't like using __weak. It penalizes code size on architectures that
> don't hook these functions. My preferred pattern is:
>
> include/linux/something.h:
>
> #include <asm/something.h>
>
> #ifndef arch_do_xyz
> static inline void arch_do_xyz() {}
> #endif
>
> arch/whatever/asm/something.h:
>
> extern void arch_do_xyz(); /* or static inline... */
> #define arch_do_xyz
>
>
> This is totally free for architectures that don't have the hooks and it can
> potentially be inlined on architectures that do have the hooks. Everyone
> wins except that it's about five additional lines of code.
>
Thanks for your guidance, this patch was deprecated previously, but I'll
take your advice the next time when writing similar patch.
> --Andy
Thanks,
Yu
next prev parent reply other threads:[~2016-10-08 16:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 16:18 [PATCH 0/4][RFC v2] x86, hotplug: Use hlt instead of mwait when resuming from hibernation Chen Yu
2016-06-25 16:18 ` [PATCH 1/4][RFC v2] PM / sleep: Avoid accessing frozen_cpus if it is NULL Chen Yu
2016-06-25 16:51 ` Pavel Machek
2016-06-26 1:16 ` Chen, Yu C
2016-06-26 4:25 ` Chen, Yu C
2016-06-25 16:18 ` [PATCH 2/4][RFC v2] PM / sleep: Introduce arch-specific hook for disable/enable nonboot cpus Chen Yu
2016-06-25 16:51 ` Pavel Machek
2016-06-26 1:19 ` Chen, Yu C
2016-10-07 19:31 ` Andy Lutomirski
2016-10-08 16:58 ` Chen Yu [this message]
2016-10-11 15:42 ` Pavel Machek
2016-06-25 16:18 ` [PATCH 3/4][RFC v2] PM / hibernate: introduce a flag to indicate resuming from hibernation Chen Yu
2016-06-25 16:53 ` Pavel Machek
2016-06-26 1:34 ` Chen, Yu C
2016-06-25 16:19 ` [PATCH 4/4] x86, hotplug: Use hlt instead of mwait when " Chen Yu
2016-10-07 19:47 ` Andy Lutomirski
2016-10-08 10:31 ` Rafael J. Wysocki
2016-10-16 16:50 ` Andy Lutomirski
2016-10-18 0:30 ` Rafael J. Wysocki
2016-10-18 1:21 ` Andy Lutomirski
2016-10-08 16:54 ` Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161008165843.GB24225@sharon \
--to=yu.c.chen@intel.com \
--cc=bp@suse.de \
--cc=brgerst@gmail.com \
--cc=cpudebug@centtech.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).