From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754181AbcJHUub (ORCPT ); Sat, 8 Oct 2016 16:50:31 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:33618 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756AbcJHUuL (ORCPT ); Sat, 8 Oct 2016 16:50:11 -0400 Date: Sat, 8 Oct 2016 15:50:03 -0500 From: Rob Herring To: gabriel.fernandez@st.com Cc: Mark Rutland , Russell King , Maxime Coquelin , Alexandre Torgue , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ludovic.barre@st.com, olivier.bideau@st.com, amelie.delaunay@st.com Subject: Re: [PATCH 5/6] clk: stm32f469: Add QSPI clock Message-ID: <20161008205003.GB17455@rob-hp-laptop> References: <1475245509-6487-1-git-send-email-gabriel.fernandez@st.com> <1475245509-6487-6-git-send-email-gabriel.fernandez@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475245509-6487-6-git-send-email-gabriel.fernandez@st.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 30, 2016 at 04:25:08PM +0200, gabriel.fernandez@st.com wrote: > From: Gabriel Fernandez > > This patch adds the QSPI clock for stm32f469 discovery board. > The gate mapping is a little bit different from stm32f429 soc. > > Signed-off-by: Gabriel Fernandez > --- > .../devicetree/bindings/clock/st,stm32-rcc.txt | 4 +- > drivers/clk/clk-stm32f4.c | 173 ++++++++++++++++++--- > 2 files changed, 158 insertions(+), 19 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt b/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt > index fee3205..eace3de 100644 > --- a/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt > +++ b/Documentation/devicetree/bindings/clock/st,stm32-rcc.txt > @@ -8,7 +8,9 @@ Please also refer to clock-bindings.txt in this directory for common clock > controller binding usage. > > Required properties: > -- compatible: Should be "st,stm32f42xx-rcc" > +- compatible: Should be: > + "st,stm32f42xx-rcc" > + "st,stm32f46xx-rcc" Generally, we don't use wildcards in compatible strings. I know there's lots of part numbers of stm32 parts which I guess are often same die with different fusing or package. Your compatible strings should be at least specific enough to identify parts that are really different die. > - reg: should be register base and length as documented in the > datasheet > - #clock-cells: 2, device nodes should specify the clock in their "clocks"