From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC 1/3] tpm_crb: expand struct crb_control_area to struct crb_regs
Date: Sun, 9 Oct 2016 21:06:13 +0300 [thread overview]
Message-ID: <20161009180613.GA26794@intel.com> (raw)
In-Reply-To: <20161009164905.GA12551@obsidianresearch.com>
On Sun, Oct 09, 2016 at 10:49:05AM -0600, Jason Gunthorpe wrote:
> On Sun, Oct 09, 2016 at 12:38:18PM +0300, Jarkko Sakkinen wrote:
> > On Sat, Oct 08, 2016 at 07:42:56PM -0600, Jason Gunthorpe wrote:
> > > On Sun, Oct 09, 2016 at 03:15:09AM +0300, Jarkko Sakkinen wrote:
> > > > + ctrl = crb_map_res(dev, priv, &io_res, buf->control_address,
> > > > + sizeof(struct crb_regs) -
> > > > + offsetof(struct crb_regs, ctrl_req));
> > > > + if (IS_ERR(ctrl))
> > > > + return PTR_ERR(ctrl);
> > > > +
> > > > + /* The control area always overrlaps IO memory mapped from the ACPI
> > > > + * object with CRB start only devices. Thus, this is perfectly safe.
> > > > + */
> > > > + priv->regs = (void *)((unsigned long)ctrl -
> > > > + offsetof(struct crb_regs, ctrl_req));
> > >
> > > Hum. No, this makes bad assumptions about the structure of iomapping.
> > >
> > > The map itself needs to be done with the adjustment:
> > >
> > > ctrl = crb_map_res(dev, priv, &io_res, buf->control_address -
> > > offsetof(struct crb_regs, ctrl_req),
> > > sizeof(struct crb_regs));
> >
> > That would be wrong address for the control area as it does not start
> > from the beginning of CRB registers.
>
> Of course, I just pointed out what the map call should look like
>
> Something like this
>
> priv->regs = crb_map_res(dev, priv, &io_res, buf->control_address -
> offsetof(struct crb_regs, ctrl_req),
> sizeof(struct crb_regs));
> ctrl = &priv->regs.ctrl_req;
>
> > I think the crb_map_io and crb_map_res are too generic. Better way to do
> > things would be to validate that assumptions for these two cases hold.
>
> If the driver is going to be using a negative offset like this, then
> it very much should validate the assumptions before doing it.
>
> and not even map these regsiters if they are not supported by
> hardware.
Yes, that's what the point I tried to make in my response in the part
that is not quoted here.
/Jarkko
next prev parent reply other threads:[~2016-10-09 18:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 0:15 [PATCH RFC 0/3] Locality support for the CRB driver Jarkko Sakkinen
2016-10-09 0:15 ` [PATCH RFC 1/3] tpm_crb: expand struct crb_control_area to struct crb_regs Jarkko Sakkinen
2016-10-09 1:42 ` Jason Gunthorpe
2016-10-09 9:38 ` Jarkko Sakkinen
2016-10-09 16:49 ` Jason Gunthorpe
2016-10-09 18:06 ` Jarkko Sakkinen [this message]
2016-10-09 18:32 ` Jarkko Sakkinen
2016-10-09 18:33 ` Jarkko Sakkinen
2016-10-09 23:07 ` Jason Gunthorpe
2016-10-10 0:25 ` [tpmdd-devel] " Winkler, Tomas
2016-10-10 3:26 ` Jason Gunthorpe
2016-10-10 4:59 ` Jarkko Sakkinen
2016-10-10 4:45 ` Jarkko Sakkinen
2016-10-09 0:15 ` [PATCH RFC 2/3] tpm_crb: encapsulate crb_wait_for_reg_32 Jarkko Sakkinen
2016-10-09 0:15 ` [PATCH RFC 3/3] tpm_crb: request and relinquish locality 0 Jarkko Sakkinen
2016-10-09 6:35 ` [tpmdd-devel] " Winkler, Tomas
2016-10-09 9:25 ` Jarkko Sakkinen
2016-10-09 9:43 ` Winkler, Tomas
2016-10-09 10:47 ` Jarkko Sakkinen
2016-10-11 9:23 [PATCH 0/3] Locality support for the CRB driver Jarkko Sakkinen
2016-10-11 9:23 ` [PATCH RFC 1/3] tpm_crb: expand struct crb_control_area to struct crb_regs Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161009180613.GA26794@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).