From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbcJJQji (ORCPT ); Mon, 10 Oct 2016 12:39:38 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:55209 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752614AbcJJQjh (ORCPT ); Mon, 10 Oct 2016 12:39:37 -0400 Date: Mon, 10 Oct 2016 22:09:28 +0530 From: "Naveen N. Rao" To: Arnaldo Carvalho de Melo Cc: Ravi Bangoria , linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, hekuang@huawei.com, jpoimboe@redhat.com, eranian@google.com, adrian.hunter@intel.com, mhiramat@kernel.org, pawel.moll@arm.com, chris.ryder@arm.com Subject: Re: [PATCH] perf annotate: Cleanup arch specific stuff References: <1474472876-2706-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1476107942-9200-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20161010162412.GK4809@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161010162412.GK4809@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16101016-0048-0000-0000-000001C71CAB X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16101016-0049-0000-0000-000046B86874 Message-Id: <20161010163928.GA3816@naverao1-tp.localdomain> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-10-10_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1610100280 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/10/10 01:24PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 10, 2016 at 07:29:02PM +0530, Ravi Bangoria escreveu: > > Move arch specific stuff from util/annotate.c to their respective > > files in util/annotate directory. > > > > No functionality changes. > > > > Signed-off-by: Ravi Bangoria > > --- > > tools/perf/util/Build | 1 + > > tools/perf/util/annotate.c | 259 +++---------------------------------- > > tools/perf/util/annotate.h | 23 ++++ > > tools/perf/util/annotate/Build | 3 + > > tools/perf/util/annotate/arm.c | 50 +++++++ > > tools/perf/util/annotate/powerpc.c | 63 +++++++++ > > tools/perf/util/annotate/x86.c | 107 +++++++++++++++ > > We already have a per arch area: tools/perf/arch/ I think this was done to support cross-arch annotate similar to the remote unwind support with util/libunwind/ - Naveen