From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753481AbcJMKEu (ORCPT ); Thu, 13 Oct 2016 06:04:50 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35248 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752987AbcJMKEm (ORCPT ); Thu, 13 Oct 2016 06:04:42 -0400 Date: Thu, 13 Oct 2016 12:04:38 +0200 From: Michal Hocko To: Joe Perches Cc: Tetsuo Handa , torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, Colin Ian King Subject: Re: linux.git: printk() problem Message-ID: <20161013100438.GH21678@dhcp22.suse.cz> References: <201610122230.DID43237.FSOHFFQOJOtVML@I-love.SAKURA.ne.jp> <20161012143525.GD9523@dhcp22.suse.cz> <1476288538.16823.9.camel@perches.com> <20161013062600.GB21678@dhcp22.suse.cz> <1476350986.2164.3.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476350986.2164.3.camel@perches.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 13-10-16 02:29:46, Joe Perches wrote: > On Thu, 2016-10-13 at 08:26 +0200, Michal Hocko wrote: [...] > > I think they are not critical and can be fix once somebody notices. > > As do I, but Linus objected to applying a patch when Colin Ian King > noticed one. > > I think the 250,000 or so uses with newlines are enough of a > precedence to keep using newlines everywhere. or simply fix missing KERN_CONTs and simply do not add any new missing \n > Now we'll have to have patches adding hundreds to thousands of the > missing KERN_CONTs for continuation lines that weren't previously a > problem in logging output but are now. I would be really surprised if we really had that many continuation lines. They should be avoided as much as possible. Hundreds of thousands just sounds more than over exaggerated... I think you are just making much bigger deal from this than necessary. Not requiring \n at the end of strings just makes a lot of sense if we have a KERN_CONT with a well defined semantic. Which was the whole point of the patch from Linus AFAIU. If there are some left overs, so what, we can fix them as soon as somebody notices. The worst thing we will get is a messy output but no information should be lost. We used to have a messy output in the past regardless and we could live with it... That being said I would be happier to know about this change before I had to scratch my head when seeing this for the first time so a heads up would be more than appreciated but fixing these issues is trivial not not worth making a lot of noise about. -- Michal Hocko SUSE Labs