From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754361AbcJMPeb (ORCPT <rfc822;w@1wt.eu>);
        Thu, 13 Oct 2016 11:34:31 -0400
Received: from mail-vk0-f48.google.com ([209.85.213.48]:35350 "EHLO
        mail-vk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753714AbcJMPeU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Oct 2016 11:34:20 -0400
Date: Thu, 13 Oct 2016 17:39:22 +0300
From: Mike Rapoport <mike.rapoport@gmail.com>
To: Edward Lipinsky <ellipinsky@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org,
        linux-fbdev@vger.kernel.org, sudip@vectorindia.org,
        teddy.wang@siliconmotion.com, linux-kernel@vger.kernel.org,
        sudipm.mukherjee@gmail.com
Subject: Re: [PATCH] staging: sm750fb: Fix printk() style warning
Message-ID: <20161013143922.GA17656@rapoport-lnx>
References: <20161002180505.GA19813@gmail.com>
 <20161002181301.GA22637@kroah.com>
 <20161007042736.GA18046@gmail.com>
 <20161007091204.GA29629@rapoport-lnx>
 <20161010143146.GA8218@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161010143146.GA8218@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote:
> 
> Thanks, that makes sense.  I tried deleting the if statement and printk()
> from ddk750_help.c, and adding the following in lynxfb_pci_probe() after
> calling hw_sm750_map() and checking for errors:
> 
> if (sm750_dev->revid == 0xfe)
> 	dev_info(&pdev->dev, "found sm750le\n");
> 
> The driver compiles, loads and unloads ok with this code.
> 
> Does this look correct?

Yep, seems just right.
 
> Regards,
> Ed L.