From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1030403AbcJQRVH (ORCPT <rfc822;w@1wt.eu>);
        Mon, 17 Oct 2016 13:21:07 -0400
Received: from mx4.wp.pl ([212.77.101.12]:29622 "EHLO mx4.wp.pl"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1030342AbcJQRUz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 17 Oct 2016 13:20:55 -0400
Date: Mon, 17 Oct 2016 18:20:49 +0100
From: Jakub Kicinski <kubakici@wp.pl>
To: David Miller <davem@davemloft.net>
Cc: jarod@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove
 usage
Message-ID: <20161017182049.4be802d1@jkicinski-Precision-T1700>
In-Reply-To: <20161017.131513.135103913948374087.davem@davemloft.net>
References: <20161017172006.4d549daa@jkicinski-Precision-T1700>
        <20161017.124954.360760874377344385.davem@davemloft.net>
        <20161017180027.4936fa15@jkicinski-Precision-T1700>
        <20161017.131513.135103913948374087.davem@davemloft.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-WP-MailID: d89bb4b83b61d41973cb6141bf9ffcdd
X-WP-AV: skaner antywirusowy poczty Nowej Poczty
X-WP-SPAM: NO 0000000 [sXM0]                               
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 17 Oct 2016 13:15:13 -0400 (EDT), David Miller wrote:
> From: Jakub Kicinski <kubakici@wp.pl>
> Date: Mon, 17 Oct 2016 18:00:27 +0100
> 
> > On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote:  
> >> From: Jakub Kicinski <kubakici@wp.pl>
> >> Date: Mon, 17 Oct 2016 17:20:06 +0100
> >>   
> >> > Please correct me if I'm wrong but it seems like we are now limiting
> >> > _all_ ethernet drivers to ETH_DATA_LEN in net-next.    
> >> 
> >> No, because the driver can increase the netdev->max_mtu value as needed.  
> > 
> > But since almost no driver is doing that, yet, right now in net-next
> > jumbo frames are not possible, no?  I thought the idea was the leave
> > the value at 0 so drivers can opt-in as needed but since setup_ether()
> > is initializing to 1500 now all ethernet driver get a default of
> > limiting to 1500.
> > 
> > IOW this patch made checks which were done only in eth_change_mtu()
> > mandatory for all drivers.  
> 
> The conversions he made were in cases where the driver's method was doing
> exactly the same thing eth_change_mtu() does not.
> 
> He strictly worked to keep the behavior identical compared to before his
> changes, please read his patches carefully.

Hm.  I must be missing something really obvious.  I just booted
net-next an hour ago and couldn't set MTU to anything larger than 1500
on either nfp or igb.  As far as I can read the code it will set the
max_mtu to 1500 in setup_ether() but none of the jumbo-capable drivers
had been touched by Jarod so far...