From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755905AbcJURx6 (ORCPT ); Fri, 21 Oct 2016 13:53:58 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:33593 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755816AbcJURxz (ORCPT ); Fri, 21 Oct 2016 13:53:55 -0400 Date: Fri, 21 Oct 2016 10:53:50 -0700 From: Bjorn Andersson To: Stephen Boyd Cc: Peter Chen , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Arnd Bergmann , Sriram Dash Subject: Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT Message-ID: <20161021175350.GU7509@tuxbot> References: <1456119133-16114-1-git-send-email-bjorn.andersson@linaro.org> <1477069159-12399-1-git-send-email-bjorn.andersson@linaro.org> <20161021173827.GJ26139@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161021173827.GJ26139@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 21 Oct 10:38 PDT 2016, Stephen Boyd wrote: > On 10/21, Bjorn Andersson wrote: > > hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent > > memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated manually > > it will not have any dma_mem or dma_ops assigned, which makes the > > dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch solves > > this by assigning the dma_mem and dma_ops based on the parent's DeviceTree > > node. > > > > Cc: Stephen Boyd > > Signed-off-by: Bjorn Andersson > > --- > > > > Hi Peter, > > > > After (once more) debugging why USB doesn't work up on the 64-bit Qualcomm > > systems I realized that we never concluded on this patch. Unfortunately I can't > > find it in my mailbox either, so resending it to restart the discussion. > > > > I thought we were going to go down the route that Arnd has been > pushing[1]? That should work, but I haven't tried it yet and > there are some more fixes on top from Sriram. I think Sriram is > taking over the patch now? > > [1] https://patchwork.kernel.org/patch/9319527/ Thanks for the pointer, I've heard about it but couldn't find it. It does make me further wonder about the multi-device model of these drivers, but I agree with you that it looks like the patch would solve our issue. Regards, Bjorn