From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935599AbcJXRqt (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Oct 2016 13:46:49 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:37936 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752054AbcJXRqs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Oct 2016 13:46:48 -0400
Date: Mon, 24 Oct 2016 13:46:45 -0400 (EDT)
Message-Id: <20161024.134645.2216722602983259081.davem@davemloft.net>
To: tushar.n.dave@oracle.com
Cc: chris.hyser@oracle.com, sowmini.varadhan@oracle.com,
        vgupta@synopsys.com, robin.murphy@arm.com, jroedel@suse.de,
        egtvedt@samfundet.no, krzk@kernel.org, rkuo@codeaurora.org,
        sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] sparc64: Add ATU (new IOMMU) support
From: David Miller <davem@davemloft.net>
In-Reply-To: <1476123127-24314-3-git-send-email-tushar.n.dave@oracle.com>
References: <1476123127-24314-1-git-send-email-tushar.n.dave@oracle.com>
        <1476123127-24314-3-git-send-email-tushar.n.dave@oracle.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 24 Oct 2016 10:46:47 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Tushar Dave <tushar.n.dave@oracle.com>
Date: Mon, 10 Oct 2016 11:12:03 -0700

> +	/* calculate size of IOTSB */
> +	table_size = (atu->size / IO_PAGE_SIZE) * 8;
> +	table = kzalloc(table_size, GFP_KERNEL);
> +	if (!table) {
> +		err = -ENOMEM;
> +		goto table_failed;
> +	}
> +	table = (void *)IO_PAGE_ALIGN((u64)table);

If you use the page allocator directly you can avoid all of these
funny alignment calculations.

> @@ -931,8 +1046,10 @@ static int pci_sun4v_probe(struct platform_device *op)
>  	struct pci_pbm_info *pbm;
>  	struct device_node *dp;
>  	struct iommu *iommu;
> +	struct atu *atu;
>  	u32 devhandle;
>  	int i, err = -ENODEV;
> +	static bool hv_atu = 1;

Please use true/false with boolean variables.

> +			hv_atu = 0;

Likewise.