From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938713AbcJXJIo (ORCPT ); Mon, 24 Oct 2016 05:08:44 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35813 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935701AbcJXJIn (ORCPT ); Mon, 24 Oct 2016 05:08:43 -0400 Date: Mon, 24 Oct 2016 10:11:15 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Jassi Brar Subject: Re: [PATCH 2/2] mailbox: sti: Fix module autoload for OF registration Message-ID: <20161024091115.GG14477@dell> References: <1476934445-17718-1-git-send-email-javier@osg.samsung.com> <1476934445-17718-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476934445-17718-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Oct 2016, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/mailbox/mailbox-sti.ko | grep alias > alias: platform:mailbox-sti > > After this patch: > > $ modinfo drivers/mailbox/mailbox-sti.ko | grep alias > alias: platform:mailbox-sti > alias: of:N*T*Cst,stih407-mailboxC* > alias: of:N*T*Cst,stih407-mailbox > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mailbox/mailbox-sti.c | 1 + > 1 file changed, 1 insertion(+) Acked-by: Lee Jones > diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox-sti.c > index a334db5c9f1c..41bcd339b68a 100644 > --- a/drivers/mailbox/mailbox-sti.c > +++ b/drivers/mailbox/mailbox-sti.c > @@ -403,6 +403,7 @@ static const struct of_device_id sti_mailbox_match[] = { > }, > { } > }; > +MODULE_DEVICE_TABLE(of, sti_mailbox_match); > > static int sti_mbox_probe(struct platform_device *pdev) > { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog