From: Daniel Vetter <daniel@ffwll.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
tang.qiang007@zte.com.cn, xie.baoyou@zte.com.cn,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
rmk+kernel@armlinux.org.uk, han.fei@zte.com.cn
Subject: Re: [PATCH] drm/i2c/tda998x: mark symbol static where possible
Date: Mon, 24 Oct 2016 16:27:45 +0200 [thread overview]
Message-ID: <20161024142745.GQ20761@phenom.ffwll.local> (raw)
In-Reply-To: <5367505.BUI00TSeFs@wuerfel>
On Mon, Oct 24, 2016 at 12:14:14PM +0200, Arnd Bergmann wrote:
> On Saturday, October 22, 2016 5:14:42 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
> >
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks this function with 'static'.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Applied to drm-misc, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2016-10-24 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 9:14 [PATCH] drm/i2c/tda998x: mark symbol static where possible Baoyou Xie
2016-10-24 10:14 ` Arnd Bergmann
2016-10-24 14:27 ` Daniel Vetter [this message]
2016-10-31 10:05 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024142745.GQ20761@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=han.fei@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=tang.qiang007@zte.com.cn \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).