From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941241AbcJXPsp (ORCPT ); Mon, 24 Oct 2016 11:48:45 -0400 Received: from mail-bl2nam02on0129.outbound.protection.outlook.com ([104.47.38.129]:63907 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935768AbcJXPsj (ORCPT ); Mon, 24 Oct 2016 11:48:39 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=zach.brown@ni.com; Date: Mon, 24 Oct 2016 10:48:21 -0500 From: Zach Brown To: Adrian Hunter CC: , , , , , Subject: Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set. Message-ID: <20161024154820.GA16144@zach-desktop> References: <1477085715-30213-1-git-send-email-zach.brown@ni.com> <1477085715-30213-3-git-send-email-zach.brown@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [130.164.62.11] X-ClientProxiedBy: BLUPR08CA0067.namprd08.prod.outlook.com (10.141.200.47) To MWHPR04MB0622.namprd04.prod.outlook.com (10.172.166.135) X-MS-Office365-Filtering-Correlation-Id: 8c884d47-ee64-4e72-d852-08d3fc253798 X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0622;2:zQr4HNdyU4c9rM3/nDE70Tg3T0qxW/+tXJuHVw9/s1RsPU8Q4GoyR57ZObaYYeivVsXn6PfqcATeiffj40pFqOVwbF7PtPae1EW10pL8KLKc/W7Rh9mXi5glDV3IwPbbm+Y5pcjABV/A630osmkXXk26VAnaruFvSSzDjdMYu26PrJr2IHWUVnOGpQPRarOil3XvAdiSDa9G93YYQmlkQw==;3:RUcT/P5adtwnhjeGx4eReAw5LNEC9UmofYAjuBFbpzIIrKIHnWihF0ZbcmJbVHUTVTnr9qtGRRlX/AqGUxkZu6T5HhXUGd+5FtIBVfBnYw9LNZfJ3aRvvtjh1Myi9u0NY7VRv7JYx5/t0jjD6NaOIw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR04MB0622; X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0622;25:ah1jsARb7Bfu1yKSwh8HcuUP8H/zNObiB8XXe0wg2xnSQLC6F7Tot0ZR4XASoIiin6p60Arzhh2PZKi/pwpw/Tt9vKWLhUghcQjXkjmUR2SZ9d6BJhdOaL7jT5TBSX75sBoNtMe2wWYUpf+xF+ECzhz8AbjbmjT6Ec2xMRWUAxUdSzPbzfEGDkHNnhsvktcttmbhKb2yn1Mz/2Tc90XFSxtzL4QWGimOiXuEpXy7XVCM0b55GD5GHtwZO2EpbPtuk4/Gl3aDPUeqvYvOK789Lw9xrpIZYaUnr2wGLhhsXMgwf00a8bPtS6uUyU11g5J/w01jbl0DV5C8MGgdDEjroxHjUxxbGakF0R91i56mGAD5IzKrGwo1B0v0cx1OrKPv9HOxMmOFHhbWnPU1UeUifb1N5YE448e3FDY47PbQdx+YzLKiwnZfBsCHLaGtFFKkO3goEDufYbb/zNYQoQtAQV0t8mvyFntxjgztq5OR6/xWX/H25JYjcU6ule6M0kiAC/qL1jc7mlZ/hdxCCcwgYxvNtipG0bqMedQ1oSq/Dnv48mopsotMyPIMabnSyDjazKBQIOOhB6dJY1fHl674Vh0h92hMJROlIkT3nxnRDhl9xyfj6hHtZ3jkA/R77c1na5Xb/CrhST/l2SM096dX6ac0DZ+ojyIdi6uVFXdnqcDfhn7MNHnAShNhl8zAbXj2B7emEfCznstZdHHPlApjhP8NT3JRTfer9FjUD0w6Jikn4UTByoCp5ITSKmdHEXli X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0622;31:HFw6AL69fR1+D12M3/7xdL8BLbheQFa02GdiY5h7ekk8SSCQAiXgOM2U1phOY9xebhtwLc7j55F4Tg+IJsFuPxAPi/7NZAjlt6HlQdmltdgajpPmb6axxC63q1x4oNhZJq/k4UAAlwR1GidIF/43yPkF7/zh9+25OcO3xwtJmQE1ToDi2qAqlvgA2PXMNzYvTMA0SoQRum9EuEDk7uENHPL0OsqImISj3tGB4VgPhxvhgL0gJ2GFSYtRgPElasK8;20:iAlPB3SqI0AuBote8ovKdTfc1rIA65xm5MCHdydXybZaXc3dhXhR9+RIIIO1/XAdIROCCbFzyp3zo7fPAidTxolNZeBXYB8WUzzudZiqsH3TxJ1zKghzuhVWDareMcq0zpRHD3rr1n9kUGVDCAKM+rb3ymFKgI4o+dFnLGqosxrLyhLSYjWXN5xafG7Wd/8ti/dPcq24qKhz7w390mJjzhevX7Ub/0NEqS7dxB5ilsS/WZaK7b6WbEtnRY6/UdGNXI+8cnih3u5nJBnM1//6SbgQUin+Dlb+XcSHl2G7eWsuR5ZR1cuSHY88mhOK6mj79ubP+8i4gmqVJJVzw0Zh22TKK3XotkW1eRQUCHuMVjjU5Qhx+SNdPVofkQ40wNfPNP7E5ssVxtcArZwMZbpzMFYPI0FZDlpLi0/+7LNLw7DMzvOKfPsVIvxxApQ82I6ywdA3+ZuqFP5FVe0u2sW9LkWnCv8axYWc/UPU2C4ZgOggIJvoEur7SGbbkuUkZLJ50ho7GBdj0+9iLCo4IwjGaPrDad/bQFBh9tW+MIhHLMIN26Ezrh1uVJL9UKu0C4EFTwEvv2jyjrzWeuGeJ2IugtYVR66e2wHW8YwogplMD3o= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(145744241990776); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:MWHPR04MB0622;BCL:0;PCL:0;RULEID:;SRVR:MWHPR04MB0622; X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0622;4:qX8he7/S2O/rNtZEihQjEZkHPwalO7KYcimnoia+oglzdgAtdGjyxmaBarVfhAYKicEgiS6rk6NXNU/Qay0MIApvaJXIeNe5Tezc4wWJulK6UMg7JWiEdiucfBbSVsxgLUMXyMBPlPyk53Occ/5y1keb3BRgBPF2ox1XjW44pqdGCVQ0Czjzc2Ws8slUaFBejFPM1Bc0yi7qlO/EmpRgM9DrBvFUuwrRsR7JXsQACMqWPSi+3WGPU6NVyFhkpXaIMu+2i8nlCFr/TRp0mpE+7uGk3mAhAYcKaE3t9xyXCl0G4HQ+fcJM0uBqO1azozSotvuUYOs6GgUs4IWV5PbIz43NVwZWbnhXfXMCoJ/P5Z2CAAN1WBQPqkKCSmKg+LztV1QEdnG2rPVXJkWHG0xKNqKfljUUZrS7EWcioUar/fgL/9qyX14NZ/kw6eT6ZxYYmZxkHU+tlFDSpdzwTy3YFg== X-Forefront-PRVS: 0105DAA385 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(24454002)(189002)(3846002)(77096005)(9686002)(83506001)(586003)(110136003)(6116002)(5660300001)(4326007)(4001350100001)(97736004)(33656002)(33716001)(23726003)(50466002)(66066001)(105586002)(97756001)(189998001)(230783001)(68736007)(7736002)(86362001)(7846002)(305945005)(54356999)(92566002)(19580405001)(101416001)(19580395003)(1076002)(46406003)(2906002)(47776003)(6666003)(50986999)(6916009)(2950100002)(76176999)(42186005)(8676002)(81156014)(81166006)(106356001)(18370500001)(107986001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR04MB0622;H:zach-desktop;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR04MB0622;23:GYA2393lhDlvpWkG1zGIjsINJUskQGIyiSIgum9+H?= =?us-ascii?Q?rD7EgNIJyJW0PhQ5+Wktdp+WMMBFhmZ/q7GCE5Cj2nsaDQLjDu0emT1eucxs?= =?us-ascii?Q?zPefDbu0otX+U9XDFgB7T0RjtlPqkAD4qQVXPy+CaDu4a2Y78wPTEAXcV0kI?= =?us-ascii?Q?ks5O3m4KRBCLKabs+q2kZtNB47GWYZu57W+pf5qP9RE/V8c390FNm1a3YQ5E?= =?us-ascii?Q?YeMsjVlzHI8wc82cWqPXREgR3TlEDHc9LNtXI/lFT3utP4q52P/bVv/sOBPo?= =?us-ascii?Q?wy87rwjwmVjsOjXHbkPZUfFbOsI1eVBLyCgt2XZVmcXo7LmG/usJz5FA20zH?= =?us-ascii?Q?LShGnCqM5siH74xQS5xbF1d0mUdMUH8uheaCGTGC/YTDkFP3Vdql8spG1gkf?= =?us-ascii?Q?5YBYjW0HQBsO2+KqPt3XoRc3k7HAPkBDXGlhAVhr7UKz0bWLSsXSa+zH8MCr?= =?us-ascii?Q?5NDps4VCqSzuus+i9z96cjV2POQO/Yb1ac1XC17CIMe4zIy0RxLQlvP/B9Z2?= =?us-ascii?Q?yzT0gM4/ZTe4UfbnhQhDtY19t4lc5HpvH9ai4BNq/jDmX0N7A2a3b1EU5j9M?= =?us-ascii?Q?uS8NyC2fsVlWQqGLPJtBhTNY+bjMHIDIwLF8+Bq6lpalb7Jq7cMjKkiHONwe?= =?us-ascii?Q?fFwxyiSGKTrEd1A/sOEyHsdQDgDwLsiCMK43/JLkqnBjgp9yV8f8A0fXm3Fm?= =?us-ascii?Q?YNPJAk79K5TqS3nNfPx7Uq6dgFf0XPR+NjjQB3mg7edJyF+aQtsWUh92CmuL?= =?us-ascii?Q?YH6XyH/ETi9cKQ0/H11raJKWPsyvFrQiKbFQAjH2wvzXLBZOgCEtHcapW9jG?= =?us-ascii?Q?nvixMBRd+Np8rpwTb/4hDi+WEodVGOf0hMDmosMM3LQuc0tdKAVqM6Hin+WD?= =?us-ascii?Q?bi8a7/ypNmKZV+Ve0CGtoCdOAtvvDKAN3dzYtX9M+lpZwdK1pPw+eN6tO0Na?= =?us-ascii?Q?RTERGFGFPirUrhXCenb8DrhDyc2AQX2C7Ab6Qi2f9A02iEmQdI6BsGTIK2++?= =?us-ascii?Q?Jrb8ftw8iqodKYfaOELLNCqa8J4aLQH96KGBlXgw1sd+GgPdEykV+8bte/MW?= =?us-ascii?Q?yGU0yqkRDn0reYXctAAn+Ht2a5PU1E7m71NcIjsSdgdeN6XvmwekO00tMlUT?= =?us-ascii?Q?nfIibGAkj4Lmjd2d/8kK9k57hMr95GZGZCB88e824HCSJOoW4tcSeScN10Or?= =?us-ascii?Q?7FZxJCAX2di6kxOaqDZobzmDmbDxfQeq6UsE/qtWn34HKNRH0uF1hd15KM/W?= =?us-ascii?Q?HsvlaBC4iFKumxT7Ls=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR04MB0622;6:TDS8jFeuIKQwZHAOyA6YyuivfVZYEC9L4wzlG3JBwNO89zWNh4iIp9FvNFNhaUh3Z6i6mxlfW2qdmYrHoUEiOSESCvycqZY5dPKzT6Dlz/u71MqopsQHK030k2sj/Rjonsn/Rvbo1VbgIgCNmI9TprzpMxPgytiExJeqNaQxITKi4E1N+nXPIYkFE0jQXDB0UdxVArs/uJnamIgCQAeZS66Ru/xbUAj2GZUaiHvXPHpGeaDOdijaJB3XNVK99TjkwQYRfMg3GXsahrncWNYtEDKFiDusn6T0Aiyp9xh+tg9wezrqylhXvAJClNlorG52;5:r2vML96pU8omdrijJJSdOsYgJj8SzWin82kixD7Ao8zEaF7jWbJYjVR2TohO96a1LWVQIv44XmUDp7NSB70j73fvPo5nJYJCcJ3wyQJQnLwzCxncvy7kETs2m2pyDnFkpSAEKmjPUDI9CcIa1797ykfQ3VaROAsF3KJKppmKr2E=;24:6iZO4/whR3SOabxD6r7l5WRknpQer/HsrDKwdiLygpt1dX7M7lPPdm/KYhVlsfKFIEUVr4+q90oiJXceilJsAza0fo3XVZ3RrjzhPrMr/+0=;7:CEV8e9QSkVlrucQsgQXIUhY0EQeuRtxFUGVDS0ANzWWjlYaD+BPcwfrdjsGxZw7heb83FQSvhrWWV+uO3NmUb4+KJgbd3vOchc4xFYjV1zbqZQ8AduZ+gr/FoAoAqgE++g5S334pBcSpjEIYpKB9V5j5DrfQSqGeNaJApm7gBHXyT/sFeUM2PlsbKJvdMqszcoKaHhrEFaSpvRPyKzLEZ6OXBDi3HMp8I7QVeqSt9NuGCfDtrBUkVfefXU1Djz8kiCeilCJUgnjlgb29qXPcthHXBvctcBkFED+0/xYXtMQuMOdsi/4ZhiwR3680Q9ZfUlbf7gFCOpIBqYdl8+RRlHBjxeRORhxj4RbVq8FLLG8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ni.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2016 15:48:35.6437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR04MB0622 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2016 at 10:34:46AM +0300, Adrian Hunter wrote: > On 22/10/16 00:35, Zach Brown wrote: > > When the sdhci-cap-speed-modes-broken DT property is set, the driver > > will ignore the bits of the capability registers that correspond to > > speed modes. > > > > Signed-off-by: Zach Brown > > --- > > drivers/mmc/host/sdhci.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > > index 1e25b01..59c62d3 100644 > > --- a/drivers/mmc/host/sdhci.c > > +++ b/drivers/mmc/host/sdhci.c > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > > > @@ -3013,10 +3014,19 @@ void __sdhci_read_caps(struct sdhci_host *host, u16 *ver, u32 *caps, u32 *caps1) > > > > host->caps = caps ? *caps : sdhci_readl(host, SDHCI_CAPABILITIES); > > > > + if (of_property_read_bool(mmc_dev(host->mmc)->of_node, > > + "sdhci-cap-speed-modes-broken")) > > It rather begs the question: if you are going to do something sdhci > specific, why not just read the whole of the caps register from DT? > Throwing out the whole of the caps register seems like overkill. Also there are some things set by the caps that are not available in the DT. For example, SDHCI_CAN_64BIT is set by the cap register and is used in sdhci_setup_host to set host->flags SDHCI_USE_64_BIT_DMA.