From: Stephen Boyd <sboyd@codeaurora.org>
To: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
Cc: mturquette@baylibre.com, orson.zhai@spreadtrum.com,
baolin.wang@spreadtrum.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, ben.li@spreadturm.com
Subject: Re: [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks
Date: Tue, 25 Oct 2016 13:40:08 -0700 [thread overview]
Message-ID: <20161025204008.GE26139@codeaurora.org> (raw)
In-Reply-To: <20161022081448.GB32560@spreadtrum.com>
On 10/22, Xiaolong Zhang wrote:
> On 四, 10月 20, 2016 at 04:01:03下午 -0700, Stephen Boyd wrote:
> > On 10/11, Orson Zhai wrote:
> > > From: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
> > >
> > > When common kernel setups fixed clock, of_clk_provider will be registerred.
> > > But there is no clkdev being registerred at the same time. This will make
> > > it difficult to get the clock by using clk_get(NULL, con_id).
> > >
> > > Add clkdev register for fixed-rate and fixed-factor clock and ignore
> > > the error if any.
> > >
> > > Signed-off-by: Xiaolong Zhang <xiaolong.zhang@spreadtrum.com>
> > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com>
> > > ---
> >
> > Why are we using clkdev lookups for clks populated from DT?
> > Shouldn't we be able to point to them from the consumers that
> > would also be in DT? I'm a little lost.
> >
> The clk_get interface allows the first argument as NULL. We just assure
> consumers can get the clock from DT or by clock name.
Ok. The first argument to clk_get() really shouldn't be NULL. It
should be the device pointer for the device that is associated
with the clk you want to get. The clock name (second argument to
clk_get()) should be device specific and not some globally unique
identifier. It seems that you're using the clk_get() API
incorrectly.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-10-25 20:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 11:13 [PATCH] clk: Register clkdev after setup of fixed-rate and fixed-factor clocks Orson Zhai
2016-10-20 23:01 ` Stephen Boyd
2016-10-22 8:14 ` Xiaolong Zhang
2016-10-25 20:40 ` Stephen Boyd [this message]
2016-11-12 5:19 ` Xiaolong Zhang
2016-11-24 0:38 ` Stephen Boyd
2016-11-24 7:39 ` Xiaolong Zhang
2016-11-29 21:10 ` Stephen Boyd
2016-12-03 5:46 ` Xiaolong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025204008.GE26139@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=baolin.wang@spreadtrum.com \
--cc=ben.li@spreadturm.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orson.zhai@spreadtrum.com \
--cc=xiaolong.zhang@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).