From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941977AbcJYVZF (ORCPT ); Tue, 25 Oct 2016 17:25:05 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:49575 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932538AbcJYVZE (ORCPT ); Tue, 25 Oct 2016 17:25:04 -0400 From: Arnd Bergmann To: Greg Kroah-Hartman Cc: Oleg Drokin , Patrick Farrell , lustre-devel@lists.lustre.org, Bobi Jam , James Simmons , Olaf Weber , James Simmons , Jinshan Xiong , "John L . Hammond" , Liang Zhen , Arnd Bergmann , Andreas Dilger , Shivani Bhardwaj , Andriy Skulysh , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] staging: lustre: remove broken dead code in cfs_cpt_table_create_pattern Date: Tue, 25 Oct 2016 23:22:30 +0200 Message-Id: <20161025212310.2346367-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:7W0oAOshT7uqLm4rImRICH6qwRyUoMBqopbxdGIaZVI7cGrpvpq Kdt9m9fEYNJemYDEnrDJWQRJfpDor5dy3giJlgeeZYIMTqamTWC5WMTqZ2hM/ntiVWTbRPP Bbpb+pyShSH7SWIDsCXtMb0lgx0YxKAlbAshjbOHtaEK/IMUTtAJmT1PRt8/VWyfnoGs1Ke 78X9ErMkqYoPkjz7yew8w== X-UI-Out-Filterresults: notjunk:1;V01:K0:UrTYncXno54=:iuMzMhjdKl4qAHQp6Jn3HN mlQFwcDjIQ2rtnFbRbd46h10W0gJY3VHa8/GJ8Rop6I1lFnZAZyOwlOLasTzdPLuEZjOmxUF7 EuppY9lpoKL9lRTJmasyXOSCPZeZfZY6GKTG3BMmctEOJsAJW/o+OUz41A1QDZ4epvdHIB1Co Cs+cgQV6l3VtIK1NtQW6Duf6sLPB/rKuvgOVD+f0MzFMZRkzp3q9oa47bB7ShPxnpiY9x9cda imXFimwvNkPpKEM1JFE37KD/lGceFl4AHNKjafLOT8kUFNPd6ohJKSk8yN4SYiC3riWjK/wqF 8kP456NmjSW3cqBvdnBCN1qpeqo9fCdf4cV9cHtSaKc5xYQ5LeXukHz9CkxqIX3zpxeotLS17 q8C2mL/uNfaGzvH1RhwVnVdVOYpweqTbzaXXyJXPNxZFT5XWTgpyMoZ25mt9QbafhvC1qAR/L CkyLgSeuV0mt0ZAdMl3pgGLZxi1OAejljxTgmx7DmUTuPir1Lph/9cQk2sSwIMkLizwKx853F RSNwpiZwrbqNhWpyHwGzP2NgJY2paSVtFSl9QoIECEfgbvYNvhxM38vY6lYgselyCvBwTBvB1 gOYecuGlZHNrbMIzFX1ewC8ACg5SuQgcTfEee6Um6j/cUMenq02WFAJV3b0GED53BuimtEToP eV2cBcA6SYxmT+hDNRVYVshFbcYu7fhYcitWEMtNUxEl5668Np9QtNX7cC+t4jgu6C3E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After a recent bugfix, we get a warning about the use of an uninitialized variable: drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In function 'cfs_cpt_table_create_pattern': drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c:833:7: error: 'str' may be used uninitialized in this function [-Werror=maybe-uninitialized] This part of the function used to not do anything as we would reassign the 'str' pointer to something else right away, but now we pass an uninitialized pointer into 'strchr', which can cause a kernel page fault or worse. Fixes: 239fd5d41f9b ("staging: lustre: libcfs: shortcut to create CPT from NUMA topology") Signed-off-by: Arnd Bergmann --- drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c b/drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c index 464b27923ac0..6a31521f6ae0 100644 --- a/drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c +++ b/drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c @@ -829,13 +829,6 @@ cfs_cpt_table_create_pattern(char *pattern) int c; int i; - for (ncpt = 0;; ncpt++) { /* quick scan bracket */ - str = strchr(str, '['); - if (!str) - break; - str++; - } - str = cfs_trimwhite(pattern); if (*str == 'n' || *str == 'N') { pattern = str + 1; -- 2.9.0