linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: broonie@kernel.org, wens@csie.org, linux-spi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size
Date: Wed, 26 Oct 2016 10:55:28 +0200	[thread overview]
Message-ID: <20161026085528.vjjypbfmfbhvileb@lukather> (raw)
In-Reply-To: <1477465231-17704-1-git-send-email-mr.nuke.me@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

On Wed, Oct 26, 2016 at 12:00:30AM -0700, Alexandru Gagniuc wrote:
> This is the seventh attempt to get this patch in. I was prompted to look
> into this again as someone recently remarked:
> 
> " cool, to bad spi does not work properly on allwinner..."
> 
> Two and a half years ago,  we were told this will all be handled with DMA.
> A year or so ago, we were told this will all be handled with DMA.
> A week or so ago, we were told this will all be handled with DMA.
> 
> See the pattern?
> When DMA finally takes over, this fallback path is not mutually exclusive.

I definitely agree, and we had this patch in the CHIP kernel for quite
some time, working like a charm.

I was planning to respin it in the next few days, glad to see you took
care of it :)

Mark, any comments on this? For the record, it already has my Acked-by.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  parent reply	other threads:[~2016-10-26 22:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26  7:00 [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Alexandru Gagniuc
2016-10-26  7:00 ` [PATCH] " Alexandru Gagniuc
2016-10-29 18:12   ` Applied "spi: sun4i: Allow transfers larger than FIFO size" to the spi tree Mark Brown
2016-10-26  8:55 ` Maxime Ripard [this message]
2016-10-27 11:14   ` [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size Mark Brown
2016-10-27 21:27     ` Maxime Ripard
2016-10-27 22:47       ` Mark Brown
2016-11-02 17:47         ` Maxime Ripard
2016-10-26 10:07 ` Mark Brown
2016-10-26 16:06   ` Alex Gagniuc
2016-10-26 16:45     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161026085528.vjjypbfmfbhvileb@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mr.nuke.me@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).