From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755955AbcJZQ7G (ORCPT ); Wed, 26 Oct 2016 12:59:06 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:52080 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755000AbcJZQ7D (ORCPT ); Wed, 26 Oct 2016 12:59:03 -0400 Date: Wed, 26 Oct 2016 17:57:53 +0100 From: Mark Brown To: Chen-Yu Tsai Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Mark Rutland , Russell King , Maxime Ripard , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com Message-ID: <20161026165753.GC25322@sirena.org.uk> References: <20161003110804.28235-1-wens@csie.org> <20161003110804.28235-3-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NU0Ex4SbNnrxsi6C" Content-Disposition: inline In-Reply-To: <20161003110804.28235-3-wens@csie.org> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 77.103.18.231 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 02/12] ASoC: dapm: Implement stereo mixer control support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NU0Ex4SbNnrxsi6C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 03, 2016 at 07:07:54PM +0800, Chen-Yu Tsai wrote: > While DAPM is mono or single channel, its controls can be shared between > widgets, such as sharing one stereo mixer control between the left and > right channel widgets. > This patch introduces support for such shared mixer controls. Based on this changelog I'm really not sure what the intended semantic of this change is which makes it difficult to review. What are you expecting these controls to look like and how are you expecting them to work? > -static void dapm_set_mixer_path_status(struct snd_soc_dapm_path *p, int i) > +static void dapm_set_mixer_path_status(struct snd_soc_dapm_path *p, int i, > + int nth_path) It looks like the goal is to attach more than one path to a single control somehow? --NU0Ex4SbNnrxsi6C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYEOCQAAoJECTWi3JdVIfQj+UH/iH8X9VuZPct23NxnN5MHN9c l1ionrvDoYi5JcroaBY2lM88Nw2uu4ADypQ2p1aBhv/W5EYkLXvgH22+rgnxVCv8 eqIBJKf9O2hRFMZeTDWMpM3BsDr0DJ7nYuFMIlCQF/2AwjRL3YXkvo2UafX5hZW1 Pz3B0f+8YtdKwRrMv0Vs+xXVzVXcrxHTORbxSvsEGBVWOP3hYQh/2BaZTgmTj/RY 8CY/nN7iuny7zNlSfk4KKxWj5ZDTlnKc27dleRfvPqmuSPphGVhBufO28X5sc67B S6Bj3bAWFhiD7QmB7mFDUVifAayUAkiLRMJ812l+5EMxtZKjbjugrOs+Lpk0cgY= =RhEI -----END PGP SIGNATURE----- --NU0Ex4SbNnrxsi6C--