From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935834AbcJ0C4h (ORCPT ); Wed, 26 Oct 2016 22:56:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55580 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932332AbcJ0C4g (ORCPT ); Wed, 26 Oct 2016 22:56:36 -0400 Date: Wed, 26 Oct 2016 21:56:33 -0500 From: Josh Poimboeuf To: Oleg Nesterov Cc: Andy Lutomirski , Roman Pen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Tejun Heo , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 1/1] kthread: allocate kthread structure using kmalloc Message-ID: <20161027025633.x4suabgcogrualso@treble> References: <20161025110508.9052-1-roman.penyaev@profitbricks.com> <20161025140333.GB4326@redhat.com> <20161025154301.GA12015@redhat.com> <20161026141359.GA6893@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161026141359.GA6893@redhat.com> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 27 Oct 2016 02:56:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2016 at 04:14:00PM +0200, Oleg Nesterov wrote: > +/* > + * TODO: kill it and use to_kthread(). But we still need the users > + * like kthread_stop() which has to sync with the exiting kthread. > + */ > static struct kthread *to_live_kthread(struct task_struct *k) Now that the kthread struct is no longer on the stack, are the try_get_task_stack() and its corresponding put_task_stack()'s still needed? -- Josh