From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943185AbcJ0PBZ (ORCPT ); Thu, 27 Oct 2016 11:01:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43792 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932442AbcJ0PBW (ORCPT ); Thu, 27 Oct 2016 11:01:22 -0400 Date: Thu, 27 Oct 2016 12:14:19 +0100 From: Mark Brown To: Maxime Ripard Cc: Alexandru Gagniuc , wens@csie.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20161027111419.GK25322@sirena.org.uk> References: <1477465231-17704-1-git-send-email-mr.nuke.me@gmail.com> <20161026085528.vjjypbfmfbhvileb@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VJJoKLVEFXdmHQwR" Content-Disposition: inline In-Reply-To: <20161026085528.vjjypbfmfbhvileb@lukather> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v7] spi: sun4i: Allow transfers larger than FIFO size X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --VJJoKLVEFXdmHQwR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 26, 2016 at 10:55:28AM +0200, Maxime Ripard wrote: > On Wed, Oct 26, 2016 at 12:00:30AM -0700, Alexandru Gagniuc wrote: > > When DMA finally takes over, this fallback path is not mutually exclusive. > I definitely agree, and we had this patch in the CHIP kernel for quite > some time, working like a charm. > I was planning to respin it in the next few days, glad to see you took > care of it :) > Mark, any comments on this? For the record, it already has my Acked-by. Without knowing what the previous discussion was it's hard to comment, it sounds like some prior review comments are just being ignored here but since I'm not turning up anything with this subject line I've no idea what that might have been (and that's very concerning in itself given that this is apparently v7...). I'm also concerned that there isn't a version of this for sun6i, it's going to make all the cut'n'pasting between the two drivers harder if we make changes in one and not the other. If the concern from the previous reviews to do with not using DMA is there some reason it's hard to do DMA? --VJJoKLVEFXdmHQwR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYEeGJAAoJECTWi3JdVIfQSyEH/3k3GzjIYMnn0hdDfwRaqDHM RxJmHIFDd4k1HhOtoAXwiYKntHPkpY/Mw9c/VWp041QcLnXhranQW1tEZ2HyjNQJ sWrpfPy6RwCetsF3sjMF/89qFSjrSTdyJd5y9b38qUuw5IjYcUr660yFjrQtj6w1 0wsC9MXRP5ffBa74qdSljz01f49OOnIvxj8pWPGrQu95BtpSQz1TW3BYfLGdJF1o jEtTddHiWwLEi5/qPcVCHWxmLPbsxuUAvjAx2Im87FGaPDFaQtJmf6ud+vrdGi/z eY4nl8jK40ZUtWpyy/AJQP3Kcyamv3gXJSkwl89B3xIGR0+cLOXvvKBxtJuudrY= =xfxp -----END PGP SIGNATURE----- --VJJoKLVEFXdmHQwR--