From: Slawomir Stepien <sst@poczta.fm>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: ldewangan@nvidia.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Input: gpio-keys - use module_platform_driver macro
Date: Thu, 27 Oct 2016 21:11:43 +0200 [thread overview]
Message-ID: <20161027191143.GA1630@x220.localdomain> (raw)
In-Reply-To: <20161027164830.GB36933@dtor-ws>
On Oct 27, 2016 09:48, Dmitry Torokhov wrote:
> Hi Slawomir,
Hi Dmitry,
> > -late_initcall(gpio_keys_init);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Because of this we can't switch to module_platform_driver(). The
> late_initcall was requirement of one of platforms because of the probe
> ordering issues. It may be resolved now with deferred probing, but you'd
> need to confirm with all the users.
I was unaware of that. Let me look in to that more deeply. At the moment I do
not have the knowledge what will be to correct solution for that.
> > -module_exit(gpio_keys_exit);
> > +module_platform_driver(gpio_keys_device_driver);
> >
> > MODULE_LICENSE("GPL");
> > MODULE_AUTHOR("Phil Blundell <pb@handhelds.org>");
>
> Thanks.
Thank you.
--
Slawomir Stepien
prev parent reply other threads:[~2016-10-27 19:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 14:15 [PATCH] Input: gpio-keys - use module_platform_driver macro Slawomir Stepien
2016-10-27 16:48 ` Dmitry Torokhov
2016-10-27 19:11 ` Slawomir Stepien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027191143.GA1630@x220.localdomain \
--to=sst@poczta.fm \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).