From: Raphael Hertzog <hertzog@debian.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
Guillem Jover <guillem@debian.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ovl: redirect on rename-dir
Date: Fri, 28 Oct 2016 14:56:20 +0200 [thread overview]
Message-ID: <20161028125620.uusbhlcwncmicvab@home.ouaza.com> (raw)
In-Reply-To: <CAJfpegu97ce6LtMeKSHqDxZGAtCJUGgYUwOwYm9P6p8XtNXf_A@mail.gmail.com>
Hi,
On Wed, 26 Oct 2016, Miklos Szeredi wrote:
> On Tue, Oct 25, 2016 at 1:57 PM, Raphael Hertzog <hertzog@debian.org> wrote:
[ redirect feature enabled by default ]
> I think it would be safe to make it the default if upperdir is empty.
> Nonempty implies that it was created with old kernel (or it was
> crafted by hand). But there should be a way to explicitly turn it
> off; either because of the need for backward compatibility or because
> the old format is simply easier to work with for humans.
>
> How about:
>
> - If upper is nonempty, then leave redirect feature alone except when
> mount option "-oredirect=on" is used to force enabling it.
> - If upper is empty, then enable redirect feature except when mount
> option "-oredirect=off" is used to force disabling it.
Looks good, but is there some stickyness of the setting? My use case is
schroot and it always starts with an empty upperdir when I create a
temporary/throw-away chroot but if I reboot the machine, then it's possible
that schroot will remount the overlayfs with a non-empty upperdir
(the temporary chroot is preserved until I explicitly end the chroot).
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/
next prev parent reply other threads:[~2016-10-28 12:56 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 7:34 [PATCH 0/3] overlayfs: allow moving directory trees Miklos Szeredi
2016-10-25 7:34 ` [PATCH 1/3] ovl: check fs features Miklos Szeredi
2016-10-25 11:24 ` Amir Goldstein
2016-11-05 20:40 ` Amir Goldstein
2016-10-25 7:34 ` [PATCH 2/3] vfs: export vfs_path_lookup() Miklos Szeredi
2016-10-25 7:34 ` [PATCH 3/3] ovl: redirect on rename-dir Miklos Szeredi
2016-10-25 11:57 ` Raphael Hertzog
2016-10-26 11:12 ` Miklos Szeredi
2016-10-28 12:56 ` Raphael Hertzog [this message]
2016-10-28 12:59 ` Miklos Szeredi
2016-11-06 19:14 ` Konstantin Khlebnikov
2016-11-07 8:07 ` Miklos Szeredi
2016-11-07 9:58 ` Konstantin Khlebnikov
2016-11-07 10:04 ` Miklos Szeredi
2016-11-07 10:08 ` Konstantin Khlebnikov
2016-11-07 13:38 ` Amir Goldstein
2016-11-10 22:56 ` Amir Goldstein
2016-11-11 9:46 ` Konstantin Khlebnikov
2016-11-11 10:06 ` Miklos Szeredi
2016-11-11 12:42 ` Amir Goldstein
2016-11-13 9:11 ` Amir Goldstein
2016-11-07 11:03 ` Raphael Hertzog
2016-11-07 11:31 ` Konstantin Khlebnikov
2016-11-07 13:42 ` Raphael Hertzog
2016-11-10 22:39 ` Miklos Szeredi
2016-11-11 9:41 ` Konstantin Khlebnikov
2016-11-13 10:00 ` Amir Goldstein
2016-11-14 16:25 ` Amir Goldstein
2016-11-16 22:00 ` Miklos Szeredi
2016-11-18 15:37 ` Amir Goldstein
2016-11-20 11:39 ` Amir Goldstein
2016-11-21 9:54 ` Miklos Szeredi
2016-11-21 10:13 ` Amir Goldstein
2016-11-21 10:16 ` Miklos Szeredi
2016-11-22 13:42 ` Amir Goldstein
2016-10-25 12:49 ` Amir Goldstein
2016-10-26 11:26 ` Miklos Szeredi
2016-10-26 12:11 ` Amir Goldstein
2016-10-26 12:51 ` Miklos Szeredi
2016-10-26 19:56 ` Amir Goldstein
2016-10-28 16:15 ` Al Viro
2016-11-03 15:50 ` Miklos Szeredi
2016-11-04 9:29 ` Amir Goldstein
2016-11-04 13:48 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028125620.uusbhlcwncmicvab@home.ouaza.com \
--to=hertzog@debian.org \
--cc=guillem@debian.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).