From: David Miller <davem@davemloft.net>
To: mlord@pobox.com
Cc: nic_swsd@realtek.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] r8152: Fix broken RX checksums.
Date: Sun, 30 Oct 2016 23:53:42 -0400 (EDT) [thread overview]
Message-ID: <20161030.235342.134481656830778556.davem@davemloft.net> (raw)
In-Reply-To: <1f847ae0-4928-01e7-f1e7-3cbc37529961@pobox.com>
From: Mark Lord <mlord@pobox.com>
Date: Sun, 30 Oct 2016 22:07:25 -0400
> On 16-10-30 08:57 PM, David Miller wrote:
>> From: Mark Lord <mlord@pobox.com>
>> Date: Sun, 30 Oct 2016 19:28:27 -0400
>>
>>> The r8152 driver has been broken since (approx) 3.16.xx
>>> when support was added for hardware RX checksums
>>> on newer chip versions. Symptoms include random
>>> segfaults and silent data corruption over NFS.
>>>
>>> The hardware checksum logig does not work on the VER_02
>>> dongles I have here when used with a slow embedded system CPU.
>>> Google reveals others reporting similar issues on Raspberry Pi.
>>>
>>> So, disable hardware RX checksum support for VER_02, and fix
>>> an obvious coding error for IPV6 checksums in the same function.
>>>
>>> Because this bug results in silent data corruption,
>>> it is a good candidate for back-porting to -stable >= 3.16.xx.
>>>
>>> Signed-off-by: Mark Lord <mlord@pobox.com>
>>
>> Applied and queued up for -stable, thanks.
>
> Thanks. Now that this is taken care of, I do wonder if perhaps
> RX checksums ought to be enabled at all for ANY versions of this chip?
You should really start a dialogue with the developer who has been
making the most, if not all, of the major changes to this driver over
the past few years, Hayes Wang.
next prev parent reply other threads:[~2016-10-31 3:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 22:36 [PATCH] drivers/net/usb/r8152 fix broken rx checksums Mark Lord
2016-10-26 22:54 ` Mark Lord
2016-10-30 21:22 ` David Miller
2016-10-30 23:48 ` Paul Bolle
2016-10-30 23:28 ` [PATCH net] r8152: Fix broken RX checksums Mark Lord
2016-10-31 0:57 ` David Miller
2016-10-31 2:07 ` Mark Lord
2016-10-31 3:53 ` David Miller [this message]
2016-10-31 8:14 ` Hayes Wang
2016-10-31 13:24 ` Mark Lord
2016-11-02 18:29 ` Mark Lord
2016-11-04 12:13 ` Mark Lord
[not found] ` <201611030159.uA31x0np004648@rtits1.realtek.com>
2016-11-03 8:56 ` Hayes Wang
2016-11-03 11:43 ` Mark Lord
2016-11-04 13:50 ` Mark Lord
2016-11-04 20:13 ` Mark Lord
[not found] ` <201611041425.uA4EPwCw018176@rtits1.realtek.com>
2016-11-09 13:09 ` Hayes Wang
2016-11-09 13:19 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161030.235342.134481656830778556.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mlord@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).