From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756042AbcJ3UEP (ORCPT ); Sun, 30 Oct 2016 16:04:15 -0400 Received: from onstation.org ([52.200.56.107]:54906 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752842AbcJ3UEM (ORCPT ); Sun, 30 Oct 2016 16:04:12 -0400 Date: Sun, 30 Oct 2016 16:04:09 -0400 From: Brian Masney To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, lars@metafoo.de, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, Mark.Rutland@arm.com Subject: Re: [PATCH 07/10] staging: iio: tsl2583: convert illuminance0_calibscale sysfs attr to use iio_chan_spec Message-ID: <20161030200409.GA14808@basecamp.onstation.org> References: <1477648821-3786-1-git-send-email-masneyb@onstation.org> <1477648821-3786-8-git-send-email-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 30, 2016 at 06:37:40PM +0000, Jonathan Cameron wrote: > On 28/10/16 11:00, Brian Masney wrote: > > The illuminance0_calibscale sysfs attribute is not currently created by > > the IIO core. This patch adds the appropriate mask to iio_chan_spec, > > along with the appropriate data handling in the read_raw() and > > write_raw() functions, so that the sysfs attribute is created by the IIO > > core. With this change, this sysfs entry will have its prefix changed > > from illuminance0_ to in_illuminance_. > > > > Signed-off-by: Brian Masney > Hmm. Could probably have computed the mean on the fly but fine as is. Hi Jonathan, Thanks for your feedback. I'll have another patch set ready for you by next weekend with my next round of cleanups to that driver. I'll change this so that it calculates the mean on the fly unless I hear otherwise from you. Brian