linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Rob Herring <robh@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>,
	ivo.g.dimitrov.75@gmail.com, sre@kernel.org,
	pali.rohar@gmail.com, linux-media@vger.kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	mchehab@osg.samsung.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] media: et8ek8: add device tree binding documentation
Date: Tue, 1 Nov 2016 00:47:39 +0200	[thread overview]
Message-ID: <20161031224739.GA3217@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <20161030204134.hpmfrnqhd4mg563o@rob-hp-laptop>

Hi Rob and Pavel,

On Sun, Oct 30, 2016 at 03:41:34PM -0500, Rob Herring wrote:
> On Sun, Oct 23, 2016 at 09:17:06PM +0200, Pavel Machek wrote:
> > 
> > Add device tree binding documentation for toshiba et8ek8 sensor.
> > 
> > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > ---
> > 
> > diff from v3: explain what clock-frequency means
> > 
> > 
> > diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > new file mode 100644
> > index 0000000..54863cf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt
> > @@ -0,0 +1,51 @@
> > +Toshiba et8ek8 5MP sensor
> > +
> > +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device
> > +
> > +More detailed documentation can be found in
> > +Documentation/devicetree/bindings/media/video-interfaces.txt .
> > +
> > +
> > +Mandatory properties
> > +--------------------
> > +
> > +- compatible: "toshiba,et8ek8"
> > +- reg: I2C address (0x3e, or an alternative address)
> > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> > +- clocks: External clock to the sensor
> > +- clock-frequency: Frequency of the external clock to the sensor. Camera
> > +  driver will set this frequency on the external clock.
> 
> This is fine if the frequency is fixed (e.g. an oscillator), but you 
> should use the clock binding if clocks are programable.

We've discussed the matter here (v3):

<URL:http://www.spinics.net/lists/linux-media/msg101210.html>

<URL:http://www.spinics.net/lists/linux-media/msg101233.html>

Pavel, could you add to the desciption e.g.:

"The clock frequency is a pre-determined frequency known to be suitable to
the board."

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

  reply	other threads:[~2016-10-31 22:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-23 19:17 Pavel Machek
2016-10-23 20:06 ` Sakari Ailus
2016-10-30 20:41 ` Rob Herring
2016-10-31 22:47   ` Sakari Ailus [this message]
2016-11-03 12:47   ` Pavel Machek
2016-11-03 22:20     ` Sakari Ailus
2016-11-07 10:36       ` Pavel Machek
2016-11-07 10:46   ` [PATCH v5] " Pavel Machek
2016-11-11 12:17     ` Pavel Machek
2016-11-14 16:20     ` Rob Herring
2016-11-14 18:30     ` [PATCH v6] " Pavel Machek
2016-11-14 18:39       ` Rob Herring
2016-12-20 13:05       ` Sakari Ailus
2016-12-21 13:20         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161031224739.GA3217@valkosipuli.retiisi.org.uk \
    --to=sakari.ailus@iki.fi \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@osg.samsung.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --subject='Re: [PATCH v4] media: et8ek8: add device tree binding documentation' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).