From: David Miller <davem@davemloft.net>
To: Larry.Finger@lwfinger.net
Cc: john@zgus.com, Jes.Sorensen@redhat.com, kvalo@codeaurora.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower
Date: Wed, 02 Nov 2016 22:58:42 -0400 (EDT) [thread overview]
Message-ID: <20161102.225842.248777008402902889.davem@davemloft.net> (raw)
In-Reply-To: <10e32bb4-fe16-6a0f-eaf4-1142c23e7b56@lwfinger.net>
From: Larry Finger <Larry.Finger@lwfinger.net>
Date: Wed, 2 Nov 2016 20:00:03 -0500
> On 10/30/2016 05:21 AM, John Heenan wrote:
>> Code tests show data returned by rtl8xxxu_read8(priv, REG_CR), used to
>> set
>> macpower, is never 0xea. It is only ever 0x01 (first time after
>> modprobe)
>> using wpa_supplicant and 0x00 thereafter using wpa_supplicant. These
>> results
>> occurs with 'Fix for authentication failure' [PATCH 1/2] in place.
>>
>> Whatever was returned, code tests always showed that at least
>> rtl8xxxu_init_queue_reserved_page(priv);
>> is always required. Not called if macpower set to true.
>>
>> Please see cover letter, [PATCH 0/2], for more information from tests.
>
> That cover letter will NOT be included in the commit message, thus
> referring to it here is totally pointless.
This is why when a patch series is added to GIT, the cover letter
must be added to the merge commit that adds that series.
It is therefore perfectly valid to refer to such text from a
commit contained by that merge commit.
prev parent reply other threads:[~2016-11-03 2:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1477769750.git.john@zgus.com>
2016-10-30 10:20 ` [PATCH 1/2] rtl8xxxu: Fix for authentication failure John Heenan
2016-11-03 1:00 ` Larry Finger
2016-11-03 7:10 ` John Heenan
2016-11-03 15:39 ` Larry Finger
2016-10-30 10:21 ` [PATCH 2/2] rtl8xxxu: Fix for bogus data used to determine macpower John Heenan
2016-10-30 12:00 ` Jes Sorensen
2016-10-30 13:56 ` John Heenan
2016-10-30 23:02 ` Jes Sorensen
2016-11-03 8:41 ` Joe Perches
2016-11-03 15:43 ` Larry Finger
2016-11-04 13:56 ` Jes Sorensen
2016-11-03 1:00 ` Larry Finger
2016-11-03 2:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102.225842.248777008402902889.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=john@zgus.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).