From: Andi Shyti <andi.shyti@samsung.com>
To: Sean Young <sean@mess.org>
Cc: "David Härdeman" <david@hardeman.nu>,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Andi Shyti" <andi@etezian.org>
Subject: Re: [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices
Date: Wed, 02 Nov 2016 13:39:30 +0900 [thread overview]
Message-ID: <20161102043929.eaf7nlje2cru7nky@gangnam.samsung> (raw)
In-Reply-To: <20161101103408.GA15939@gofer.mess.org>
Hi Sean,
> > > Andi, it would be good to know what the use-case for the original change is.
> >
> > the use case is the ir-spi itself which doesn't need the lirc to
> > perform any waiting on its behalf.
>
> Here is the crux of the problem: in the ir-spi case no wait will actually
> happen here, and certainly no "over-wait". The patch below will not change
> behaviour at all.
>
> In the ir-spi case, "towait" will be 0 and no wait happens.
>
> I think the code is already in good shape but somehow there is a
> misunderstanding. Did I miss something?
We can just drop this patch, it's just something small that is
bothering me.
I will send a new patchset without this one.
Thanks,
Andi
next prev parent reply other threads:[~2016-11-02 4:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-01 17:16 [PATCH v2 0/7] Add support for IR transmitters Andi Shyti
2016-09-01 17:16 ` [PATCH v2 1/7] [media] rc-main: assign driver type during allocation Andi Shyti
2016-09-01 21:23 ` Sean Young
2016-09-02 5:25 ` Andi Shyti
2016-09-01 17:16 ` [PATCH v2 2/7] [media] rc-main: split setup and unregister functions Andi Shyti
2016-09-01 17:16 ` [PATCH v2 3/7] [media] rc-core: add support for IR raw transmitters Andi Shyti
2016-09-01 21:31 ` Sean Young
2016-09-02 0:21 ` kbuild test robot
2016-09-01 17:16 ` [PATCH v2 4/7] [media] rc-ir-raw: do not generate any receiving thread for " Andi Shyti
2016-09-01 17:16 ` [PATCH v2 5/7] [media] ir-lirc-codec: don't wait any transmitting time for tx only devices Andi Shyti
2016-09-02 8:41 ` Sean Young
2016-10-27 7:44 ` Andi Shyti
2016-10-27 14:36 ` Sean Young
2016-10-31 14:31 ` David Härdeman
2016-10-31 17:05 ` Sean Young
2016-11-01 6:51 ` Andi Shyti
2016-11-01 10:34 ` Sean Young
2016-11-02 4:39 ` Andi Shyti [this message]
2016-09-01 17:16 ` [PATCH v2 6/7] Documentation: bindings: add documentation for ir-spi device driver Andi Shyti
2016-09-01 21:40 ` Rob Herring
2016-09-02 5:33 ` Andi Shyti
2016-09-12 13:27 ` Rob Herring
2016-09-01 17:16 ` [PATCH v2 7/7] [media] rc: add support for IR LEDs driven through SPI Andi Shyti
2016-09-01 21:12 ` Sean Young
2016-09-02 5:27 ` Andi Shyti
2016-09-02 8:43 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102043929.eaf7nlje2cru7nky@gangnam.samsung \
--to=andi.shyti@samsung.com \
--cc=andi@etezian.org \
--cc=david@hardeman.nu \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).