From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Archit Taneja <architt@codeaurora.org>,
Mark Brown <broonie@kernel.org>, David Airlie <airlied@linux.ie>,
Fabio Estevam <fabio.estevam@freescale.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
Thierry Reding <treding@nvidia.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>, Simon <horms@verge.net.au>,
linux-renesas-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jose Abreu <joabreu@synopsys.com>
Subject: Re: [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support
Date: Wed, 2 Nov 2016 08:27:58 +0000 [thread overview]
Message-ID: <20161102082758.GV1041@n2100.armlinux.org.uk> (raw)
In-Reply-To: <871syu4r3x.wl%kuninori.morimoto.gx@renesas.com>
On Wed, Nov 02, 2016 at 01:18:35AM +0000, Kuninori Morimoto wrote:
> + platform = platform_device_register_full(&pdevinfo);
> + if (IS_ERR_OR_NULL(platform))
> + return PTR_ERR(platform);
This is wrong. If platform is NULL, PTR_ERR() will return zero, which
will be interpreted as success. Please, avoid using IS_ERR_OR_NULL(),
it leads to exactly this kind of cockup - and it's unnecessary here
because platform_device_register_full() does not return NULL.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-11-02 8:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 1:18 [PATCH v3] drm: bridge: add DesignWare HDMI I2S audio support Kuninori Morimoto
2016-11-02 8:27 ` Russell King - ARM Linux [this message]
2016-11-07 3:50 ` Kuninori Morimoto
2016-11-07 14:56 ` Russell King - ARM Linux
2016-11-08 0:20 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102082758.GV1041@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=architt@codeaurora.org \
--cc=broonie@kernel.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabio.estevam@freescale.com \
--cc=horms@verge.net.au \
--cc=joabreu@synopsys.com \
--cc=koji.matsuoka.xm@renesas.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).