From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Michael Neuling <mikey@neuling.org>,
linuxppc-dev@lists.ozlabs.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 3/4] cputime/powerpc/s390: make scaled cputime arch specific
Date: Wed, 2 Nov 2016 10:38:20 +0100 [thread overview]
Message-ID: <20161102093820.GC2604@redhat.com> (raw)
In-Reply-To: <9ad862f2-5665-08d6-4e5d-793637efcb66@de.ibm.com>
On Wed, Nov 02, 2016 at 10:11:22AM +0100, Christian Borntraeger wrote:
> On 10/31/2016 01:36 PM, Stanislaw Gruszka wrote:
> > Only s390 and powerpc have hardware facilities allowing to measure
> > cputimes scaled by frequency. On all other architectures
> > utimescaled/stimescaled are equal to utime/stime (however they are
> > accounted separately).
> >
> > Patch remove {u,s}timescaled accounting on all architectures except
> > powerpc and s390, where those values are explicitly accounted on proper
> > places.
>
> If we remove it everywhere else (and assuming that there are no users then)
> I aks myself if we should remove this as well from s390.
There is one user of scaled cputimes values, it is taskstats (to users
space are exported ac_utimescaled, ac_stimescaled and
cpu_scaled_run_real_total which is calculated based on scaled times).
However on other than powerpc and s390 architectures scaled times are
equal to normal times (this is also true for older powerpc's without
SPURR/PURR registers).
Stanislaw
next prev parent reply other threads:[~2016-11-02 9:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 12:36 [PATCH 0/4] cputime: some optimizations and cleanups Stanislaw Gruszka
2016-10-31 12:36 ` [PATCH 1/4] cputime/powerpc: remove cputime_last_delta global variable Stanislaw Gruszka
2016-11-03 0:50 ` Paul Mackerras
2016-10-31 12:36 ` [PATCH 2/4] cputime/powerpc: remove cputime_to_scaled() Stanislaw Gruszka
2016-11-03 0:51 ` Paul Mackerras
2016-10-31 12:36 ` [PATCH 3/4] cputime/powerpc/s390: make scaled cputime arch specific Stanislaw Gruszka
2016-10-31 13:02 ` kbuild test robot
2016-10-31 13:13 ` [PATCH v2 " Stanislaw Gruszka
2016-10-31 14:13 ` [PATCH " kbuild test robot
2016-10-31 16:21 ` [PATCH v3 " Stanislaw Gruszka
2016-11-15 10:51 ` [tip:sched/core] sched/cputime, powerpc, s390: Make " tip-bot for Stanislaw Gruszka
2016-11-02 9:11 ` [PATCH 3/4] cputime/powerpc/s390: make " Christian Borntraeger
2016-11-02 9:38 ` Stanislaw Gruszka [this message]
2016-11-02 21:22 ` Martin Schwidefsky
2016-10-31 12:36 ` [PATCH 4/4] cputime: simplify task_cputime() Stanislaw Gruszka
2016-11-09 13:01 ` [PATCH 0/4] cputime: some optimizations and cleanups Frederic Weisbecker
2016-11-15 2:06 [GIT PULL] cputime: Scaled cputime " Frederic Weisbecker
2016-11-15 2:06 ` [PATCH 3/4] cputime/powerpc/s390: Make scaled cputime arch specific Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102093820.GC2604@redhat.com \
--to=sgruszka@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=fweisbec@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).