From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755618AbcKBKk4 (ORCPT ); Wed, 2 Nov 2016 06:40:56 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:49863 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754014AbcKBKku (ORCPT ); Wed, 2 Nov 2016 06:40:50 -0400 X-AuditID: cbfee61b-f793d6d000005a2a-90-5819c2a54943 From: Andi Shyti To: Mauro Carvalho Chehab , Sean Young , Rob Herring , Mark Rutland , Richard Purdie , Jacek Anaszewski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v3 3/6] [media] rc-core: add support for IR raw transmitters Date: Wed, 02 Nov 2016 19:40:07 +0900 Message-id: <20161102104010.26959-4-andi.shyti@samsung.com> X-Mailer: git-send-email 2.10.1 In-reply-to: <20161102104010.26959-1-andi.shyti@samsung.com> References: <20161102104010.26959-1-andi.shyti@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEIsWRmVeSWpSXmKPExsVy+t9jAd1lhyQjDC4UWmw/8ozVYvGP50wW 84+cY7Xovfqc0eLyrjlsFlvfrGO06NmwldVi6fWLTBarn1VYtO49wm6xe9dTVouFT7+zOPB4 rJm3htHj+pJPzB6bVnWyeSx5Y+2xpf8uu8ee+T9YPfq2rGL0+LxJLoAjys0mIzUxJbVIITUv OT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2CW4ZXZ9esBW8 kKu49PwpSwPjQckuRk4OCQETiX+rnzJC2GISF+6tZ+ti5OIQEljKKLHg0GN2COcjo8TEvT/Y QKrYBDQlmm7/AKsSEXjLKHFo+iuwdmaBvYwSez/6gNjCAj4SD67eZAGxWQRUJf4s38vcxcjB wStgLXF4sx3ENnmJC1dPgZVwCthI/G0EWcYJtMxa4sD1/ewTGHkXMDKsYpRILUguKE5KzzXK Sy3XK07MLS7NS9dLzs/dxAiOj2fSOxgP73I/xCjAwajEw1twWSJCiDWxrLgy9xCjBAezkgjv t32SEUK8KYmVValF+fFFpTmpxYcYTYHumsgsJZqcD4zdvJJ4QxNzE3NjAwtzS0sTIyVx3sbZ z8KFBNITS1KzU1MLUotg+pg4OKWAgWds5ub50Pv/AYPH3Y3350+q39tpvEk1hfX8kePpN6ra +L4YVjDezRJsZ6hb7SU7wdngxMaqh/d/Lz756sukFb0LOxVORs68O9074XRCbrsHy5/jChxd L4uPBpVOOP3JTYPZocQz+SrPxeztah9PzStysba4UBTB6Jre8H7OVN26HFkF413uSizFGYmG WsxFxYkA1TyYZ6UCAAA= X-MTR: 20000000000000000@CPGS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IR raw transmitter driver type is specified in the enum rc_driver_type as RC_DRIVER_IR_RAW_TX which includes all those devices that transmit raw stream of bit to a receiver. The data are provided by userspace applications, therefore they don't need any input device allocation, but still they need to be registered as raw devices. Suggested-by: Sean Young Signed-off-by: Andi Shyti --- drivers/media/rc/rc-main.c | 42 +++++++++++++++++++++++++----------------- include/media/rc-core.h | 9 ++++++--- 2 files changed, 31 insertions(+), 20 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 7ab1b32..0d2f440 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -1363,20 +1363,24 @@ struct rc_dev *rc_allocate_device(enum rc_driver_type type) if (!dev) return NULL; - dev->input_dev = input_allocate_device(); - if (!dev->input_dev) { - kfree(dev); - return NULL; - } + if (type != RC_DRIVER_IR_RAW_TX) { + dev->input_dev = input_allocate_device(); + if (!dev->input_dev) { + kfree(dev); + return NULL; + } + + dev->input_dev->getkeycode = ir_getkeycode; + dev->input_dev->setkeycode = ir_setkeycode; + input_set_drvdata(dev->input_dev, dev); - dev->input_dev->getkeycode = ir_getkeycode; - dev->input_dev->setkeycode = ir_setkeycode; - input_set_drvdata(dev->input_dev, dev); + setup_timer(&dev->timer_keyup, ir_timer_keyup, + (unsigned long)dev); - spin_lock_init(&dev->rc_map.lock); - spin_lock_init(&dev->keylock); + spin_lock_init(&dev->rc_map.lock); + spin_lock_init(&dev->keylock); + } mutex_init(&dev->lock); - setup_timer(&dev->timer_keyup, ir_timer_keyup, (unsigned long)dev); dev->dev.type = &rc_dev_type; dev->dev.class = &rc_class; @@ -1476,7 +1480,7 @@ static int rc_setup_rx_device(struct rc_dev *dev) static void rc_free_rx_device(struct rc_dev *dev) { - if (!dev) + if (!dev || dev->driver_type == RC_DRIVER_IR_RAW_TX) return; ir_free_table(&dev->rc_map); @@ -1506,7 +1510,8 @@ int rc_register_device(struct rc_dev *dev) atomic_set(&dev->initialized, 0); dev->dev.groups = dev->sysfs_groups; - dev->sysfs_groups[attr++] = &rc_dev_protocol_attr_grp; + if (dev->driver_type != RC_DRIVER_IR_RAW_TX) + dev->sysfs_groups[attr++] = &rc_dev_protocol_attr_grp; if (dev->s_filter) dev->sysfs_groups[attr++] = &rc_dev_filter_attr_grp; if (dev->s_wakeup_filter) @@ -1524,11 +1529,14 @@ int rc_register_device(struct rc_dev *dev) dev->input_name ?: "Unspecified device", path ?: "N/A"); kfree(path); - rc = rc_setup_rx_device(dev); - if (rc) - goto out_dev; + if (dev->driver_type != RC_DRIVER_IR_RAW_TX) { + rc = rc_setup_rx_device(dev); + if (rc) + goto out_dev; + } - if (dev->driver_type == RC_DRIVER_IR_RAW) { + if (dev->driver_type == RC_DRIVER_IR_RAW || + dev->driver_type == RC_DRIVER_IR_RAW_TX) { if (!raw_init) { request_module_nowait("ir-lirc-codec"); raw_init = true; diff --git a/include/media/rc-core.h b/include/media/rc-core.h index f8ca557..b6f7419 100644 --- a/include/media/rc-core.h +++ b/include/media/rc-core.h @@ -32,13 +32,16 @@ do { \ /** * enum rc_driver_type - type of the RC output * - * @RC_DRIVER_SCANCODE: Driver or hardware generates a scancode - * @RC_DRIVER_IR_RAW: Driver or hardware generates pulse/space sequences. - * It needs a Infra-Red pulse/space decoder + * @RC_DRIVER_SCANCODE: Driver or hardware generates a scancode + * @RC_DRIVER_IR_RAW: Driver or hardware generates pulse/space sequences. + * It needs a Infra-Red pulse/space decoder + * @RC_DRIVER_IR_RAW_TX: Device transmitter only, + driver requires pulse/space data sequence. */ enum rc_driver_type { RC_DRIVER_SCANCODE = 0, RC_DRIVER_IR_RAW, + RC_DRIVER_IR_RAW_TX, }; /** -- 2.10.1