From: Lee Jones <lee.jones@linaro.org>
To: Richard Vidal-Dorsch <richard.dorsch@gmail.com>
Cc: linus.walleij@linaro.org, gnurou@gmail.com, jdelvare@suse.com,
linux@roeck-us.net, wsa@the-dreams.de, jingoohan1@gmail.com,
tomi.valkeinen@ti.com, wim@iguana.be,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org,
k.kozlowski@samsung.com, jo.sunga@advantech.com,
weilun.huang@advantech.com, andrew.chou@advantech.com
Subject: Re: [PATCH v4 1/6] Add Advantech iManager MFD core driver
Date: Thu, 3 Nov 2016 08:41:47 +0000 [thread overview]
Message-ID: <20161103084147.GY13127@dell> (raw)
In-Reply-To: <20161102083751.6335-2-richard.dorsch@gmail.com>
On Wed, 02 Nov 2016, Richard Vidal-Dorsch wrote:
> This patch adds Advantech iManager Embedded Controller MFD core driver.
> This mfd core dirver provides an interface for GPIO, I2C, HWmon,
> Watchdog, and Backlight/Brightness control.
>
> Signed-off-by: Richard Vidal-Dorsch <richard.dorsch@gmail.com>
> ---
> drivers/mfd/Kconfig | 18 +
> drivers/mfd/Makefile | 1 +
> drivers/mfd/imanager-core.c | 941 ++++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/imanager-ec.h | 228 ++++++++++
> include/linux/mfd/imanager.h | 221 ++++++++++
> 5 files changed, 1409 insertions(+)
> create mode 100644 drivers/mfd/imanager-core.c
> create mode 100644 include/linux/mfd/imanager-ec.h
> create mode 100644 include/linux/mfd/imanager.h
After a brief review, it is my belief that this looks like a platform
driver, which should live in drivers/platform/.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-11-03 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 8:37 [PATCH v4 0/6] Advantech iManager EC driver set Richard Vidal-Dorsch
2016-11-02 8:37 ` [PATCH v4 1/6] Add Advantech iManager MFD core driver Richard Vidal-Dorsch
2016-11-03 8:41 ` Lee Jones [this message]
2016-11-02 8:37 ` [PATCH v4 2/6] Add Advantech iManager GPIO driver Richard Vidal-Dorsch
2016-11-05 8:29 ` Linus Walleij
2016-11-02 8:37 ` [PATCH v4 3/6] Add Advantech iManager HWmon driver Richard Vidal-Dorsch
2016-11-02 8:37 ` [PATCH v4 4/6] Add Advantech iManager I2C driver Richard Vidal-Dorsch
2016-11-02 8:37 ` [PATCH v4 5/6] Add Advantech iManager Backlight driver Richard Vidal-Dorsch
2016-11-02 8:37 ` [PATCH v4 6/6] Add Advantech iManager Watchdog driver Richard Vidal-Dorsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103084147.GY13127@dell \
--to=lee.jones@linaro.org \
--cc=andrew.chou@advantech.com \
--cc=gnurou@gmail.com \
--cc=jdelvare@suse.com \
--cc=jingoohan1@gmail.com \
--cc=jo.sunga@advantech.com \
--cc=k.kozlowski@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=richard.dorsch@gmail.com \
--cc=tomi.valkeinen@ti.com \
--cc=weilun.huang@advantech.com \
--cc=wim@iguana.be \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).