* [PATCH] block: drop q argument from bsg_validate_sgv4_hdr
@ 2016-11-03 9:38 Johannes Thumshirn
2016-11-03 13:56 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Thumshirn @ 2016-11-03 9:38 UTC (permalink / raw)
To: Jens Axboe
Cc: Hannes Reinecke, Christoph Hellwig, Linux Kernel Mailinglist,
Linux Block Layer Mailinglist, Johannes Thumshirn
bsg_validate_sgv4_hdr() doesn't care about the request_queue, so drop it
from it's arguments.
Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
---
block/bsg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/bsg.c b/block/bsg.c
index d214e92..8a05a40 100644
--- a/block/bsg.c
+++ b/block/bsg.c
@@ -176,7 +176,7 @@ static int blk_fill_sgv4_hdr_rq(struct request_queue *q, struct request *rq,
* Check if sg_io_v4 from user is allowed and valid
*/
static int
-bsg_validate_sgv4_hdr(struct request_queue *q, struct sg_io_v4 *hdr, int *rw)
+bsg_validate_sgv4_hdr(struct sg_io_v4 *hdr, int *rw)
{
int ret = 0;
@@ -226,7 +226,7 @@ bsg_map_hdr(struct bsg_device *bd, struct sg_io_v4 *hdr, fmode_t has_write_perm,
hdr->dout_xfer_len, (unsigned long long) hdr->din_xferp,
hdr->din_xfer_len);
- ret = bsg_validate_sgv4_hdr(q, hdr, &rw);
+ ret = bsg_validate_sgv4_hdr(hdr, &rw);
if (ret)
return ERR_PTR(ret);
--
2.10.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: drop q argument from bsg_validate_sgv4_hdr
2016-11-03 9:38 [PATCH] block: drop q argument from bsg_validate_sgv4_hdr Johannes Thumshirn
@ 2016-11-03 13:56 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2016-11-03 13:56 UTC (permalink / raw)
To: Johannes Thumshirn
Cc: Hannes Reinecke, Christoph Hellwig, Linux Kernel Mailinglist,
Linux Block Layer Mailinglist
On 11/03/2016 03:38 AM, Johannes Thumshirn wrote:
> bsg_validate_sgv4_hdr() doesn't care about the request_queue, so drop it
> from it's arguments.
Thanks, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-03 13:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-03 9:38 [PATCH] block: drop q argument from bsg_validate_sgv4_hdr Johannes Thumshirn
2016-11-03 13:56 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).