From: Borislav Petkov <bp@alien8.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/entry64: move comment about informing of context tracking in right place
Date: Thu, 3 Nov 2016 12:24:35 +0100 [thread overview]
Message-ID: <20161103112434.o6wx4zjdnxodrvzr@pd.tnic> (raw)
In-Reply-To: <20161024112234.21898-1-kuleshovmail@gmail.com>
On Mon, Oct 24, 2016 at 05:22:34PM +0600, Alexander Kuleshov wrote:
> We are switching to kernel gsbase if an IRQ come from usermode with swpags.
"... if an IRQ comes from ..."
Also, you mean SWAPGS. Instruction names in allcaps please and spelled
correctly please.
> Now there is comment which describes this:
>
> IRQ from user mode. Switch to kernel gsbase and inform context tracking that
> we're in kernel mode.
>
> But now we execute swapgs, next TRACE_IRQS_OFF and only then the
> CALL_enter_from_user_mode macro expands to the informing of
> context tracking about this event. Let's move part of comment to
> the right place where actual call to context tracing occured.
I don't agree with that change - SWAPGS is part of what the comment
explains so it looks just fine where it is.
For future patches:
Please integrate scripts/checkpatch.pl in your patch creation workflow:
WARNING: 'occured' may be misspelled - perhaps 'occurred'?
#27:
the right place where actual call to context tracing occured.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
prev parent reply other threads:[~2016-11-03 11:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 11:22 [PATCH] x86/entry64: move comment about informing of context tracking in right place Alexander Kuleshov
2016-11-03 11:24 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103112434.o6wx4zjdnxodrvzr@pd.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).