From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759772AbcKCSPE (ORCPT ); Thu, 3 Nov 2016 14:15:04 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38461 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbcKCSPD (ORCPT ); Thu, 3 Nov 2016 14:15:03 -0400 Date: Thu, 3 Nov 2016 19:14:52 +0100 From: Daniel Lezcano To: Vineet Gupta Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, Noam Camus , Alexey.Brodkin@synopsys.com Subject: Re: [PATCH 9/9] clocksource: import ARC timer driver Message-ID: <20161103181452.GL1859@mai> References: <35bde193-8492-83e0-fb03-8385d8afd007@synopsys.com> <1477954096-770-1-git-send-email-vgupta@synopsys.com> <1477954096-770-10-git-send-email-vgupta@synopsys.com> <20161101204257.GG1506@mai> <188a2912-3369-19a3-86af-cbb154ff7e44@synopsys.com> <20161103173317.GI1859@mai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161103173317.GI1859@mai> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2016 at 06:33:17PM +0100, Daniel Lezcano wrote: [ ... ] > As now the clksrc-probe is correctly handling the errors, if the rtc and the > gfrc are both defined in the DT, you can fail to init the rtc one with a simple > test in the init function: > > if (IS_DEFINED(CONFIG_SMP)) > return -EINVAL; > > So, you can inconditionaly compile in both RTC and GFRC, no ? That would be > cleaner and prevent a different kernel config. Ah, actually I suggested something which is already there :) Perhaps, the if SMP does not make sense in the Kconfig, no ?