From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: vinod.koul@intel.com, Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@stlinux.com,
dan.j.williams@intel.com, patrice.chotard@st.com,
ohad@wizery.com, arnaud.pouliquen@st.com, lee.jones@linaro.org,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v10 03/11] remoteproc: Update Kconfig setup to 'depends on REMOTEPROC'
Date: Thu, 3 Nov 2016 14:24:39 -0700 [thread overview]
Message-ID: <20161103212439.GS25787@tuxbot> (raw)
In-Reply-To: <1475931154-1021-4-git-send-email-peter.griffin@linaro.org>
On Sat 08 Oct 05:52 PDT 2016, Peter Griffin wrote:
> Make REMOTEPROC core a selectable kconfig option, and update
> remoteproc client drivers to 'depends on' the core. This avoids
> some nasty Kconfig recursive dependency issues. Also when using
> menuconfig client drivers will be hidden until the core has been
> enabled.
>
> Documentation/kbuild/kconfig-language.txt:
>
> Note:
> select should be used with care. select will force
> a symbol to a value without visiting the dependencies.
> By abusing select you are able to select a symbol FOO even
> if FOO depends on BAR that is not set.
> In general use select only for non-visible symbols
> (no prompts anywhere) and for symbols with no dependencies.
> That will limit the usefulness but on the other hand avoid
> the illegal configurations all over.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Sorry, I missed this patch in the set - but spotted it in linux-next.
I still don't like the change, but remoteproc has dependencies so I
guess I have to pick it until we fix that.
It's however not okay to take this patch through the DMA tree, as it
effectively stops me from introducing any changes in the rproc tree.
Further more, it's not based on v4.9, so it currently introduces another
Kconfig dependency problem - that I can't fix in my tree without
conflicting with Vinod's.
So, Vinod, can you please drop this patch from your tree? I'll pick it
up for now.
Regards,
Bjorn
> ---
> drivers/remoteproc/Kconfig | 21 ++++++++++++---------
> 1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index a7bedc6..decdcbe 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -1,20 +1,21 @@
> menu "Remoteproc drivers"
>
> -# REMOTEPROC gets selected by whoever wants it
> config REMOTEPROC
> - tristate
> + tristate "Support for Remote Processor subsystem"
> depends on HAS_DMA
> select CRC32
> select FW_LOADER
> select VIRTIO
> select VIRTUALIZATION
>
> +if REMOTEPROC
> +
> config OMAP_REMOTEPROC
> tristate "OMAP remoteproc support"
> depends on HAS_DMA
> depends on ARCH_OMAP4 || SOC_OMAP5
> depends on OMAP_IOMMU
> - select REMOTEPROC
> + depends on REMOTEPROC
> select MAILBOX
> select OMAP2PLUS_MBOX
> select RPMSG
> @@ -34,7 +35,7 @@ config OMAP_REMOTEPROC
> config STE_MODEM_RPROC
> tristate "STE-Modem remoteproc support"
> depends on HAS_DMA
> - select REMOTEPROC
> + depends on REMOTEPROC
> default n
> help
> Say y or m here to support STE-Modem shared memory driver.
> @@ -44,7 +45,7 @@ config STE_MODEM_RPROC
> config WKUP_M3_RPROC
> tristate "AMx3xx Wakeup M3 remoteproc support"
> depends on SOC_AM33XX || SOC_AM43XX
> - select REMOTEPROC
> + depends on REMOTEPROC
> help
> Say y here to support Wakeup M3 remote processor on TI AM33xx
> and AM43xx family of SoCs.
> @@ -57,8 +58,8 @@ config WKUP_M3_RPROC
> config DA8XX_REMOTEPROC
> tristate "DA8xx/OMAP-L13x remoteproc support"
> depends on ARCH_DAVINCI_DA8XX
> + depends on REMOTEPROC
> select CMA if MMU
> - select REMOTEPROC
> select RPMSG
> help
> Say y here to support DA8xx/OMAP-L13x remote processors via the
> @@ -84,9 +85,9 @@ config QCOM_Q6V5_PIL
> tristate "Qualcomm Hexagon V5 Peripherial Image Loader"
> depends on OF && ARCH_QCOM
> depends on QCOM_SMEM
> + depends on REMOTEPROC
> select MFD_SYSCON
> select QCOM_MDT_LOADER
> - select REMOTEPROC
> help
> Say y here to support the Qualcomm Peripherial Image Loader for the
> Hexagon V5 based remote processors.
> @@ -94,7 +95,7 @@ config QCOM_Q6V5_PIL
> config ST_REMOTEPROC
> tristate "ST remoteproc support"
> depends on ARCH_STI
> - select REMOTEPROC
> + depends on REMOTEPROC
> help
> Say y here to support ST's adjunct processors via the remote
> processor framework.
> @@ -102,6 +103,8 @@ config ST_REMOTEPROC
>
> config ST_SLIM_REMOTEPROC
> tristate
> - select REMOTEPROC
> + depends on REMOTEPROC
> +
> +endif # REMOTEPROC
>
> endmenu
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-11-03 21:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 12:52 [PATCH v10 00/11] Add support for FDMA DMA controller and slim core rproc found on STi chipsets Peter Griffin
2016-10-08 12:52 ` [PATCH v10 01/11] remoteproc: st_slim_rproc: add a slimcore rproc driver Peter Griffin
2016-10-08 12:52 ` [PATCH v10 02/11] MAINTAINERS: Add st slim core rproc driver to STi section Peter Griffin
2016-10-08 12:52 ` [PATCH v10 03/11] remoteproc: Update Kconfig setup to 'depends on REMOTEPROC' Peter Griffin
2016-11-03 21:24 ` Bjorn Andersson [this message]
2016-11-14 5:12 ` Vinod Koul
2016-10-08 12:52 ` [PATCH v10 04/11] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2016-10-08 12:52 ` [PATCH v10 05/11] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin
2016-10-08 12:52 ` [PATCH v10 06/11] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2016-10-08 12:52 ` [PATCH v10 07/11] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2016-10-08 12:52 ` [PATCH v10 08/11] ARM: multi_v7_defconfig: Enable remoteproc core Peter Griffin
2016-10-08 12:52 ` [PATCH v10 09/11] ARM: multi_v7_defconfig: Enable st_remoteproc driver Peter Griffin
2016-10-08 12:52 ` [PATCH v10 10/11] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2016-10-08 12:52 ` [PATCH v10 11/11] ARM: multi_v7_defconfig: Enable STi and simple-card drivers Peter Griffin
2016-10-18 9:39 [RESEND PATCH v10 00/11] Add support for FDMA DMA controller and slim core rproc found on STi chipsets Peter Griffin
2016-10-18 9:39 ` [PATCH v10 03/11] remoteproc: Update Kconfig setup to 'depends on REMOTEPROC' Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103212439.GS25787@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=peter.griffin@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).