From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935393AbcKDPIK (ORCPT <rfc822;w@1wt.eu>);
        Fri, 4 Nov 2016 11:08:10 -0400
Received: from shards.monkeyblade.net ([184.105.139.130]:34822 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932271AbcKDPII (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Nov 2016 11:08:08 -0400
Date: Fri, 04 Nov 2016 11:07:59 -0400 (EDT)
Message-Id: <20161104.110759.1093635654135143910.davem@davemloft.net>
To: lsanfil@marvell.com
Cc: joe@perches.com, madalin.bucur@nxp.com, akpm@linux-foundation.org,
        corbet@lwn.net, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org, oss@buserror.net, ppc@mindchasers.com,
        pebolle@tiscali.nl, joakim.tjernlund@transmode.se
Subject: Re: Coding Style: Reverse XMAS tree declarations ?
From: David Miller <davem@davemloft.net>
In-Reply-To: <581C6A7D.8030704@marvell.com>
References: <20161103.155816.642712588084106823.davem@davemloft.net>
        <1478242438.1924.31.camel@perches.com>
        <581C6A7D.8030704@marvell.com>
X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 04 Nov 2016 07:08:31 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Lino Sanfilippo <lsanfil@marvell.com>
Date: Fri, 4 Nov 2016 12:01:17 +0100

> Hi,
> 
> On 04.11.2016 07:53, Joe Perches wrote:
>>
>> CHECK:REVERSE_XMAS_TREE: Prefer ordering declarations longest to
>> shortest
>> #446: FILE: drivers/net/ethernet/ethoc.c:446:
>> +			int size = bd.stat >> 16;
>> +			struct sk_buff *skb;
>>
> 
> should not this case be valid? Optically the longer line is already
> before the shorter.
> I think that the whole point in using this reverse xmas tree ordering
> is to have
> the code optically tidied up and not to enforce ordering between
> variable name lengths.

That's correct.